This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7152

phabricator: use True primitive instead of b'true' for phabupdate actions
ClosedPublic

Authored by Kwan on Oct 23 2019, 5:30 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6bff75fd19fe: phabricator: use True primitive instead of b'true' for phabupdate actions
rHG132ddd1cba85: phabricator: use True primitive instead of b'true' for phabupdate actions
rHGe57bf37eaeb5: phabricator: use True primitive instead of b'true' for phabupdate actions
Summary

Something I'd missed in the creatediff port. This didn't matter before with
the old PHP form style wireformat, but breaks with the new arcanist format.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (2 lines)

Diff 17416

hgext/phabricator.py

""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
flags = [n for n in b'accept reject abandon reclaim'.split() if opts.get(n)] flags = [n for n in b'accept reject abandon reclaim'.split() if opts.get(n)]
if len(flags) > 1: if len(flags) > 1:
raise error.Abort(_(b'%s cannot be used together') % b', '.join(flags)) raise error.Abort(_(b'%s cannot be used together') % b', '.join(flags))
actions = [] actions = []
for f in flags: for f in flags:
actions.append({b'type': f, b'value': b'true'}) actions.append({b'type': f, b'value': True})
drevs = querydrev(repo, spec) drevs = querydrev(repo, spec)
for i, drev in enumerate(drevs): for i, drev in enumerate(drevs):
if i + 1 == len(drevs) and opts.get(b'comment'): if i + 1 == len(drevs) and opts.get(b'comment'):
actions.append({b'type': b'comment', b'value': opts[b'comment']}) actions.append({b'type': b'comment', b'value': opts[b'comment']})
if actions: if actions:
params = { params = {
b'objectIdentifier': drev[b'phid'], b'objectIdentifier': drev[b'phid'],