This is an archive of the discontinued Mercurial Phabricator instance.

py3: use %d instead of %s when formatting an int into a bytestring
ClosedPublic

Authored by Kwan on Oct 23 2019, 6:10 PM.

Details

Summary

The latter wasn't noticed before since no tests exercise --confirm at all, let
alone on an existing DREV.
The second is only hit during an intermittent network issue during amending at
the end of a phabsend, so doesn't seem testable.
The first is also untested and is hit when a user creates fake D1234 tags that
get removed.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Kwan created this revision.Oct 23 2019, 6:10 PM
Kwan edited the summary of this revision. (Show Details)Oct 24 2019, 5:57 AM
Kwan updated this revision to Diff 17395.
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
Kwan edited the summary of this revision. (Show Details)Oct 24 2019, 12:44 PM
Kwan updated this revision to Diff 17397.