This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7215

py3: use %d to format an int
ClosedPublic

Authored by Kwan on Nov 2 2019, 6:22 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG742065def6ca: py3: use %d to format an int
Summary

Avoids a TypeError under py3. Fortunately this is very much an edge case since
it requires the user to have deliberately created a local tag of the form
'D\d+' that isn't truthful.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Nov 2 2019, 6:22 PM
Kwan added a commit: rHG742065def6ca: py3: use %d to format an int.Nov 4 2019, 11:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG742065def6ca: py3: use %d to format an int (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (2 lines)

Diff 17530

hgext/phabricator.py

nullid, nullid,
message=None, message=None,
user=None, user=None,
date=None, date=None,
local=True, local=True,
) )
unfi.ui.warn( unfi.ui.warn(
_( _(
b'D%s: local tag removed - does not match ' b'D%d: local tag removed - does not match '
b'Differential history\n' b'Differential history\n'
) )
% drev % drev
) )
continue continue
# Find the last node using Phabricator metadata, and make sure it # Find the last node using Phabricator metadata, and make sure it
# exists in the repo # exists in the repo