Page MenuHomePhabricator

metaedit: make it compatible with histedit
ClosedPublic

Authored by mitrandir on Sep 20 2017, 12:49 PM.

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGXeb0dfcb0a5df: metaedit: make it compatible with histedit
Summary

auto-rebasing stuff during metaedit doesn't really work well for histedit.
Let's specialcase it

Test Plan

see test

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mitrandir created this revision.Sep 20 2017, 12:49 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2017, 12:49 PM
ryanmce requested changes to this revision.Sep 20 2017, 1:20 PM
ryanmce added a subscriber: ryanmce.
ryanmce added inline comments.
hgext3rd/fbamend/metaedit.py
137

I don't think it needs to be a warning. Info probably so it shows up with -v?

187

Is there no built in way to check this from the histedit extension?

This revision now requires changes to proceed.Sep 20 2017, 1:20 PM
mitrandir added inline comments.Sep 21 2017, 8:12 AM
hgext3rd/fbamend/metaedit.py
137

I can do that.

187

Nothing that we could simply use here.

mitrandir updated this revision to Diff 1960.Sep 21 2017, 8:18 AM

s/warn/note

ryanmce accepted this revision.Sep 21 2017, 8:26 AM
This revision is now accepted and ready to land.Sep 21 2017, 8:26 AM
This revision was automatically updated to reflect the committed changes.