This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7726

commitablectx: fix the default phase
ClosedPublic

Authored by marmoute on Dec 27 2019, 11:00 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbbcf78c4ff90: commitablectx: fix the default phase
Summary

The code was ignoring the config option. Since the config option will control
the actual phase of the committed result, we better take it in account early.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 27 2019, 11:00 AM
marmoute added a commit: rHGbbcf78c4ff90: commitablectx: fix the default phase.Dec 27 2019, 12:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGbbcf78c4ff90: commitablectx: fix the default phase (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 18944

mercurial/context.py

def bookmarks(self): def bookmarks(self):
b = [] b = []
for p in self.parents(): for p in self.parents():
b.extend(p.bookmarks()) b.extend(p.bookmarks())
return b return b
def phase(self): def phase(self):
phase = phases.draft # default phase to draft phase = phases.newcommitphase(self._repo.ui)
for p in self.parents(): for p in self.parents():
phase = max(phase, p.phase()) phase = max(phase, p.phase())
return phase return phase
def hidden(self): def hidden(self):
return False return False
def children(self): def children(self):