This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8069

manifest: remove optional default= argument on flags(path)
ClosedPublic

Authored by durin42 on Feb 3 2020, 11:48 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdbbae122f5e4: manifest: remove optional default= argument on flags(path)
Summary

It had only one caller inside manifest.py, and treemanifest was
actually incorrectly implemented. treemanifest is still missing the
fastdelta() method from the interface (and so doesn't yet conform),
but this is at least progress.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 3 2020, 11:48 PM
durin42 added a commit: rHGdbbae122f5e4: manifest: remove optional default= argument on flags(path).Feb 4 2020, 1:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGdbbae122f5e4: manifest: remove optional default= argument on flags(path) (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19867

mercurial/interfaces/repository.py

"""Set the flag value for a given path. """Set the flag value for a given path.
Raises ``KeyError`` if the path is not already in the manifest. Raises ``KeyError`` if the path is not already in the manifest.
""" """
def get(path, default=None): def get(path, default=None):
"""Obtain the node value for a path or a default value if missing.""" """Obtain the node value for a path or a default value if missing."""
def flags(path, default=b''): def flags(path):
"""Return the flags value for a path or a default value if missing.""" """Return the flags value for a path (default: empty bytestring)."""
def copy(): def copy():
"""Return a copy of this manifest.""" """Return a copy of this manifest."""
def items(): def items():
"""Returns an iterable of (path, node) for items in this manifest.""" """Returns an iterable of (path, node) for items in this manifest."""
def iteritems(): def iteritems():

mercurial/manifest.py

def __nonzero__(self): def __nonzero__(self):
# nonzero is covered by the __len__ function, but implementing it here # nonzero is covered by the __len__ function, but implementing it here
# makes it easier for extensions to override. # makes it easier for extensions to override.
return len(self._lm) != 0 return len(self._lm) != 0
__bool__ = __nonzero__ __bool__ = __nonzero__
def __setitem__(self, key, node): def __setitem__(self, key, node):
self._lm[key] = node, self.flags(key, b'') self._lm[key] = node, self.flags(key)
def __contains__(self, key): def __contains__(self, key):
if key is None: if key is None:
return False return False
return key in self._lm return key in self._lm
def __delitem__(self, key): def __delitem__(self, key):
del self._lm[key] del self._lm[key]
self._lm[key] = self[key], flag self._lm[key] = self[key], flag
def get(self, key, default=None): def get(self, key, default=None):
try: try:
return self._lm[key][0] return self._lm[key][0]
except KeyError: except KeyError:
return default return default
def flags(self, key, default=b''): def flags(self, key):
try: try:
return self._lm[key][1] return self._lm[key][1]
except KeyError: except KeyError:
return default return b''
def copy(self): def copy(self):
c = manifestdict() c = manifestdict()
c._lm = self._lm.copy() c._lm = self._lm.copy()
return c return c
def items(self): def items(self):
return (x[:2] for x in self._lm.iterentries()) return (x[:2] for x in self._lm.iterentries())