( )⚙ D810 tests: add interface checks for bundle, statichttp, and union peers

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D810

tests: add interface checks for bundle, statichttp, and union peers
ClosedPublic

Authored by indygreg on Sep 24 2017, 11:51 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGafcbc6f64d27: tests: add interface checks for bundle, statichttp, and union peers
Summary

I forgot to add these when I initially wrote the test. They inherit
from localrepo.localpeer, so they should be explicitly tested.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 24 2017, 11:51 AM
Closed by commit rHGafcbc6f64d27: tests: add interface checks for bundle, statichttp, and union peers (authored by indygreg). · Explain WhySep 26 2017, 9:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-interfaces.py (6 lines)

Diff 2085

tests/test-check-interfaces.py

# Test that certain objects conform to well-defined interfaces. # Test that certain objects conform to well-defined interfaces.
from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
from mercurial import ( from mercurial import (
bundlerepo,
httppeer, httppeer,
localrepo, localrepo,
sshpeer, sshpeer,
statichttprepo,
ui as uimod, ui as uimod,
unionrepo,
) )
def checkobject(o): def checkobject(o):
"""Verify a constructed object conforms to interface rules. """Verify a constructed object conforms to interface rules.
An object must have __abstractmethods__ defined. An object must have __abstractmethods__ defined.
All "public" attributes of the object (attributes not prefixed with All "public" attributes of the object (attributes not prefixed with
def main(): def main():
ui = uimod.ui() ui = uimod.ui()
checkobject(badpeer()) checkobject(badpeer())
checkobject(httppeer.httppeer(ui, 'http://localhost')) checkobject(httppeer.httppeer(ui, 'http://localhost'))
checkobject(localrepo.localpeer(dummyrepo())) checkobject(localrepo.localpeer(dummyrepo()))
checkobject(testingsshpeer(ui, 'ssh://localhost/foo')) checkobject(testingsshpeer(ui, 'ssh://localhost/foo'))
checkobject(bundlerepo.bundlepeer(dummyrepo()))
checkobject(statichttprepo.statichttppeer(dummyrepo()))
checkobject(unionrepo.unionpeer(dummyrepo()))
main() main()