This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8227

hgit: use type_str instead of type for checking type of git objects
Changes PlannedPublic

Authored by pulkit on Mar 5 2020, 9:39 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

type returns a constant which were integers.

https://www.pygit2.org/objects.html#pygit2.Object.type

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Mar 5 2020, 9:39 AM
pulkit updated this revision to Diff 20506.Mar 5 2020, 9:44 AM
pulkit planned changes to this revision.Mar 5 2020, 10:03 AM

I should add some tests.

Revision Contents
Changeset List

PathPackages
Mhgext/git/manifest.py (2 lines)

Diff 20506

hgext/git/manifest.py

def text(self): def text(self):
assert False # TODO can this method move out of the manifest iface? assert False # TODO can this method move out of the manifest iface?
def _walkonetree(self, tree, match, subdir): def _walkonetree(self, tree, match, subdir):
for te in tree: for te in tree:
# TODO: can we prune dir walks with the matcher? # TODO: can we prune dir walks with the matcher?
realname = subdir + pycompat.fsencode(te.name) realname = subdir + pycompat.fsencode(te.name)
if te.type == r'tree': if te.type == pygit2.GIT_OBJ_TREE:
for inner in self._walkonetree( for inner in self._walkonetree(
self._git_repo[te.id], match, realname + b'/' self._git_repo[te.id], match, realname + b'/'
): ):
yield inner yield inner
if not match(realname): if not match(realname):
continue continue
yield pycompat.fsencode(realname) yield pycompat.fsencode(realname)