This is an archive of the discontinued Mercurial Phabricator instance.

Differential D831

releasenotes: raise error on simultaneous usage of flags
ClosedPublic

Authored by rishabhmadan96 on Sep 28 2017, 10:14 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG741a511492d3: releasenotes: raise error on simultaneous usage of flags
Summary

The releasenotes command is supposed to raise an error when --list and
--rev/--check flags are used together. This patch adds the above functionality.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit added a subscriber: pulkit.Sep 28 2017, 10:17 AM
pulkit added inline comments.
hgext/releasenotes.py
560

It will be cleaner if you do (_("cannot .... '--list' and '--check' "). Also since we are calling opts.get('list') three times, can we just take this out into an another variable.

pulkit accepted this revision.Sep 29 2017, 6:59 AM
Closed by commit rHG741a511492d3: releasenotes: raise error on simultaneous usage of flags (authored by rishabhmadan96). · Explain WhySep 30 2017, 2:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2168

hgext/releasenotes.py

greater than a threshold. greater than a threshold.
This means that the release notes file can be updated independently from This means that the release notes file can be updated independently from
this command and changes should not be lost when running this command on this command and changes should not be lost when running this command on
that file. A particular use case for this is to tweak the wording of a that file. A particular use case for this is to tweak the wording of a
release note after it has been added to the release notes file. release note after it has been added to the release notes file.
""" """
sections = releasenotessections(ui, repo) sections = releasenotessections(ui, repo)
if opts.get('list'):
listflag = opts.get('list')
if listflag and opts.get('rev'):
raise error.Abort(_('cannot use both \'--list\' and \'--rev\''))
if listflag and opts.get('check'):
pulkitUnsubmitted
Not Done

It will be cleaner if you do (_("cannot .... '--list' and '--check' "). Also since we are calling opts.get('list') three times, can we just take this out into an another variable.

pulkit: It will be cleaner if you do (_("cannot .... '--list' and '--check' "). Also since we are…
raise error.Abort(_('cannot use both \'--list\' and \'--check\''))
if listflag:
return _getadmonitionlist(ui, sections) return _getadmonitionlist(ui, sections)
rev = opts.get('rev') rev = opts.get('rev')
revs = scmutil.revrange(repo, [rev or 'not public()']) revs = scmutil.revrange(repo, [rev or 'not public()'])
if opts.get('check'): if opts.get('check'):
return checkadmonitions(ui, repo, sections.names(), revs) return checkadmonitions(ui, repo, sections.names(), revs)
incoming = parsenotesfromrevisions(repo, sections.names(), revs) incoming = parsenotesfromrevisions(repo, sections.names(), revs)

tests/test-releasenotes-formatting.t

$ hg init relnotes-list $ hg init relnotes-list
$ cd relnotes-list $ cd relnotes-list
$ hg releasenotes -l $ hg releasenotes -l
feature: New Features feature: New Features
bc: Backwards Compatibility Changes bc: Backwards Compatibility Changes
fix: Bug Fixes fix: Bug Fixes
perf: Performance Improvements perf: Performance Improvements
api: API Changes api: API Changes
$ cd ..
Raise error on simultaneous usage of flags
$ hg init relnotes-raise-error
$ cd relnotes-raise-error
$ hg releasenotes -r . -l
abort: cannot use both '--list' and '--rev'
[255]
$ hg releasenotes -l -c
abort: cannot use both '--list' and '--check'
[255]