This is an archive of the discontinued Mercurial Phabricator instance.

releasenotes: raise error on simultaneous usage of flags
ClosedPublic

Authored by rishabhmadan96 on Sep 28 2017, 10:14 AM.

Details

Summary

The releasenotes command is supposed to raise an error when --list and
--rev/--check flags are used together. This patch adds the above functionality.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Sep 28 2017, 10:17 AM
pulkit added inline comments.
hgext/releasenotes.py
560

It will be cleaner if you do (_("cannot .... '--list' and '--check' "). Also since we are calling opts.get('list') three times, can we just take this out into an another variable.

pulkit accepted this revision.Sep 29 2017, 6:59 AM
This revision was automatically updated to reflect the committed changes.