This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8498

rust-matchers: add timing tracing to regex compilation
ClosedPublic

Authored by Alphare on May 7 2020, 6:29 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG83c97c0bd319: rust-matchers: add timing tracing to regex compilation
Summary

This might be useful to diagnose later performance issues or just to show
the difference between engines.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.May 7 2020, 6:29 AM
Alphare added a commit: rHG83c97c0bd319: rust-matchers: add timing tracing to regex compilation.May 7 2020, 11:33 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG83c97c0bd319: rust-matchers: add timing tracing to regex compilation (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/matchers.rs (4 lines)

Diff 21286

rust/hg-core/src/matchers.rs

use std::borrow::ToOwned; use std::borrow::ToOwned;
use std::collections::HashSet; use std::collections::HashSet;
use std::fmt::{Display, Error, Formatter}; use std::fmt::{Display, Error, Formatter};
use std::iter::FromIterator; use std::iter::FromIterator;
use std::ops::Deref; use std::ops::Deref;
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
use micro_timer::timed;
#[derive(Debug, PartialEq)] #[derive(Debug, PartialEq)]
pub enum VisitChildrenSet<'a> { pub enum VisitChildrenSet<'a> {
/// Don't visit anything /// Don't visit anything
Empty, Empty,
/// Only visit this directory /// Only visit this directory
This, This,
/// Visit this directory and these subdirectories /// Visit this directory and these subdirectories
/// TODO Should we implement a `NonEmptyHashSet`? /// TODO Should we implement a `NonEmptyHashSet`?
} }
#[cfg(feature = "with-re2")] #[cfg(feature = "with-re2")]
/// Returns a function that matches an `HgPath` against the given regex /// Returns a function that matches an `HgPath` against the given regex
/// pattern. /// pattern.
/// ///
/// This can fail when the pattern is invalid or not supported by the /// This can fail when the pattern is invalid or not supported by the
/// underlying engine `Re2`, for instance anything with back-references. /// underlying engine `Re2`, for instance anything with back-references.
#[timed]
fn re_matcher( fn re_matcher(
pattern: &[u8], pattern: &[u8],
) -> PatternResult<impl Fn(&HgPath) -> bool + Sync> { ) -> PatternResult<impl Fn(&HgPath) -> bool + Sync> {
let regex = Re2::new(pattern); let regex = Re2::new(pattern);
let regex = regex.map_err(|e| PatternError::UnsupportedSyntax(e))?; let regex = regex.map_err(|e| PatternError::UnsupportedSyntax(e))?;
Ok(move |path: &HgPath| regex.is_match(path.as_bytes())) Ok(move |path: &HgPath| regex.is_match(path.as_bytes()))
} }
#[cfg(not(feature = "with-re2"))] #[cfg(not(feature = "with-re2"))]
/// Returns a function that matches an `HgPath` against the given regex /// Returns a function that matches an `HgPath` against the given regex
/// pattern. /// pattern.
/// ///
/// This can fail when the pattern is invalid or not supported by the /// This can fail when the pattern is invalid or not supported by the
/// underlying engine (the `regex` crate), for instance anything with /// underlying engine (the `regex` crate), for instance anything with
/// back-references. /// back-references.
#[timed]
fn re_matcher( fn re_matcher(
pattern: &[u8], pattern: &[u8],
) -> PatternResult<impl Fn(&HgPath) -> bool + Sync> { ) -> PatternResult<impl Fn(&HgPath) -> bool + Sync> {
use std::io::Write; use std::io::Write;
let mut escaped_bytes = vec![]; let mut escaped_bytes = vec![];
for byte in pattern { for byte in pattern {
if *byte > 127 { if *byte > 127 {