This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8512

manifest-cache: ignore IOError while writing
ClosedPublic

Authored by marmoute on May 11 2020, 3:27 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG35bb67427f63: manifest-cache: ignore IOError while writing
rHG92054972f035: manifest-cache: ignore IOError while writing
Summary

If the wcache directory is non writable for some reason (eg: belong to root).
Trying to write to it currently crash Mercurial. Instead we ignore the error and
skip writing that cache.

We should probably improve the user experience of multiple users interacting
with the same repository. However this is not an adventure for stable.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 11 2020, 3:27 AM
marmoute added a commit: rHG92054972f035: manifest-cache: ignore IOError while writing.May 11 2020, 7:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG92054972f035: manifest-cache: ignore IOError while writing (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/manifest.py (35 lines)

Diff 21347

mercurial/manifest.py

self._read = True self._read = True
self._dirty = False self._dirty = False
def write(self): def write(self):
if not self._dirty or self._opener is None: if not self._dirty or self._opener is None:
return return
# rotate backwards to the first used node # rotate backwards to the first used node
try:
with self._opener( with self._opener(
self._file, b'w', atomictemp=True, checkambig=True self._file, b'w', atomictemp=True, checkambig=True
) as fp: ) as fp:
node = self._head.prev node = self._head.prev
while True: while True:
if node.key in self._cache: if node.key in self._cache:
fp.write(node.key) fp.write(node.key)
fp.write(struct.pack(b'>L', len(node.value))) fp.write(struct.pack(b'>L', len(node.value)))
fp.write(node.value) fp.write(node.value)
if node is self._head: if node is self._head:
break break
node = node.prev node = node.prev
except IOError:
# We could not write the cache (eg: permission error)
# the content can be missing.
#
# We could try harder and see if we could recreate a wcache
# directory were we coudl write too.
#
# XXX the error pass silently, having some way to issue an error
# log `ui.log` would be nice.
pass
def __len__(self): def __len__(self):
if not self._read: if not self._read:
self.read() self.read()
return super(manifestfulltextcache, self).__len__() return super(manifestfulltextcache, self).__len__()
def __contains__(self, k): def __contains__(self, k):
if not self._read: if not self._read: