Page MenuHomePhabricator

py3: fix exception in pull when several things happen to a bookmark
ClosedPublic

Authored by valentin.gatienbaron on May 14 2020, 11:00 AM.

Details

Summary

Specifically, when changes is:

[(b'@upstream-committed', None, <function ui.status>, b'updating bookmark @upstream-committed\n'),
 (b'@upstream-committed', binary-node, <function ui.warn>, b'divergent bookmark @ stored as @upstream-committed\n')]

sorting the list raises:

TypeError: '<' not supported between instances of 'bytes' and 'NoneType'

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.