This is an archive of the discontinued Mercurial Phabricator instance.

Differential D913

test-globalopts: make the test compatible with chg
ClosedPublic

Authored by singhsrb on Oct 2 2017, 8:16 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHGf2268edf38d5: test-globalopts: make the test compatible with chg
Summary

The test fails when run with the '--chg' option. Therefore, this
commit modifies the test to make it compatible with chg.

Test Plan

Ran 'test-globalopts.t' with and without the '--chg' option.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 2 2017, 8:16 PM
quark requested changes to this revision.Oct 2 2017, 11:33 PM
quark added a subscriber: quark.

--traceback turns on traceback printing. This means chg does not do what is expected.

To unblock the test, we can explicitly document that chg is broken here:

#if chg
BROKEN: --traceback does not show --config errors.
   ...
#else
   ...
#endif
This revision now requires changes to proceed.Oct 2 2017, 11:33 PM
singhsrb updated this revision to Diff 2380.Oct 3 2017, 2:02 PM
singhsrb updated this revision to Diff 2381.Oct 3 2017, 2:10 PM
quark accepted this revision.Oct 3 2017, 8:11 PM
Closed by commit rHGf2268edf38d5: test-globalopts: make the test compatible with chg (authored by singhsrb). · Explain WhyOct 4 2017, 9:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-globalopts.t (6 lines)

Diff 2399

tests/test-globalopts.t

extra: branch=default extra: branch=default
description: description:
a a
Testing --traceback: Testing --traceback:
#if no-chg
$ hg --cwd c --config x --traceback id 2>&1 | grep -i 'traceback' $ hg --cwd c --config x --traceback id 2>&1 | grep -i 'traceback'
Traceback (most recent call last): Traceback (most recent call last):
#else
Traceback for '--config' errors not supported with chg.
$ hg --cwd c --config x --traceback id 2>&1 | grep -i 'traceback'
[1]
#endif
Testing --time: Testing --time:
$ hg --cwd a --time id $ hg --cwd a --time id
8580ff50825a tip 8580ff50825a tip
time: real * (glob) time: real * (glob)
Testing --version: Testing --version: