This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9230

rhg: add full node id support for `debugdata` command
ClosedPublic

Authored by acezar on Oct 20 2020, 9:48 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG57dc78861196: rhg: add full node id support for `debugdata` command
Summary

Unlike other later implemented commands debugdata only supported revision
number. This changeset add full node id support for consistency with other
commands.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

acezar created this revision.Oct 20 2020, 9:48 AM
durin42 requested changes to this revision.Oct 28 2020, 9:57 PM
durin42 added a subscriber: durin42.

Seems to need rebased.

This revision now requires changes to proceed.Oct 28 2020, 9:57 PM
Antoine cezar <acezar@chwitlabs.fr> added a commit: rHG57dc78861196: rhg: add full node id support for `debugdata` command.Nov 3 2020, 1:06 AM
This revision was not accepted when it landed; it landed in state Needs Revision.
Closed by commit rHG57dc78861196: rhg: add full node id support for `debugdata` command (authored by Antoine cezar <acezar@chwitlabs.fr>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23407

rust/hg-core/src/operations/debugdata.rs

} }
impl<'a> DebugData<'a> { impl<'a> DebugData<'a> {
pub fn new(rev: &'a str, kind: DebugDataKind) -> Self { pub fn new(rev: &'a str, kind: DebugDataKind) -> Self {
DebugData { rev, kind } DebugData { rev, kind }
} }
pub fn run(&mut self) -> Result<Vec<u8>, DebugDataError> { pub fn run(&mut self) -> Result<Vec<u8>, DebugDataError> {
let rev = self
.rev
.parse::<Revision>()
.or(Err(DebugDataErrorKind::InvalidRevision))?;
let root = find_root::FindRoot::new().run()?; let root = find_root::FindRoot::new().run()?;
let index_file = match self.kind { let index_file = match self.kind {
DebugDataKind::Changelog => root.join(".hg/store/00changelog.i"), DebugDataKind::Changelog => root.join(".hg/store/00changelog.i"),
DebugDataKind::Manifest => root.join(".hg/store/00manifest.i"), DebugDataKind::Manifest => root.join(".hg/store/00manifest.i"),
}; };
let revlog = Revlog::open(&index_file, None)?; let revlog = Revlog::open(&index_file, None)?;
let data = revlog.get_rev_data(rev)?;
let data = match self.rev.parse::<Revision>() {
Ok(rev) => revlog.get_rev_data(rev)?,
_ => {
let node = hex::decode(&self.rev)
.map_err(|_| DebugDataErrorKind::InvalidRevision)?;
let rev = revlog.get_node_rev(&node)?;
revlog.get_rev_data(rev)?
}
};
Ok(data) Ok(data)
} }
} }

tests/test-rhg.t

file3 file3
commit 3 (no-eol) commit 3 (no-eol)
$ rhg debugdata -m 2 $ rhg debugdata -m 2
file1\x00b8e02f6433738021a065f94175c7cd23db5f05be (esc) file1\x00b8e02f6433738021a065f94175c7cd23db5f05be (esc)
file2\x005d9299349fc01ddd25d0070d149b124d8f10411e (esc) file2\x005d9299349fc01ddd25d0070d149b124d8f10411e (esc)
file3\x002661d26c649684b482d10f91960cc3db683c38b4 (esc) file3\x002661d26c649684b482d10f91960cc3db683c38b4 (esc)
Debuging with full node id
$ rhg debugdata -c `hg log -r 0 -T '{node}'`
c8e64718e1ca0312eeee0f59d37f8dc612793856
test
0 0
file1
commit 1 (no-eol)
Cat files Cat files
$ cd $TESTTMP $ cd $TESTTMP
$ rm -rf repository $ rm -rf repository
$ hg init repository $ hg init repository
$ cd repository $ cd repository
$ echo "original content" > original $ echo "original content" > original
$ hg add original $ hg add original
$ hg commit -m "add original" original $ hg commit -m "add original" original
$ rhg cat -r 0 original $ rhg cat -r 0 original
original content original content
Cat copied file should not display copy metadata Cat copied file should not display copy metadata
$ hg copy original copy_of_original $ hg copy original copy_of_original
$ hg commit -m "add copy of original" $ hg commit -m "add copy of original"
$ rhg cat -r 1 copy_of_original $ rhg cat -r 1 copy_of_original
original content original content