This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9239

test: avoid bashisms in test-transaction-rollback-on-sigpipe.t
ClosedPublic

Authored by mplamann on Oct 22 2020, 12:42 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGb713e4cae2d7: test: avoid bashisms in test-transaction-rollback-on-sigpipe.t

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mplamann created this revision.Oct 22 2020, 12:42 PM
martinvonz accepted this revision.Oct 22 2020, 1:02 PM
martinvonz added a subscriber: martinvonz.

That seems to fix the failing test on both py2 and py3. Thanks!

This revision is now accepted and ready to land.Oct 22 2020, 1:02 PM

Revision Contents
Changeset List

Diff 23283

tests/test-transaction-rollback-on-sigpipe.t

Test that, when an hg push is interrupted and the remote side recieves SIGPIPE, Test that, when an hg push is interrupted and the remote side recieves SIGPIPE,
the remote hg is able to successfully roll back the transaction. the remote hg is able to successfully roll back the transaction.
$ hg init -q remote $ hg init -q remote
$ hg clone -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" -q ssh://user@dummy/`pwd`/remote local $ hg clone -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" -q ssh://user@dummy/`pwd`/remote local
$ check_for_abandoned_transaction() { $ check_for_abandoned_transaction() {
> [[ -f $TESTTMP/remote/.hg/store/journal ]] && echo "Abandoned transaction!" > [ -f $TESTTMP/remote/.hg/store/journal ] && echo "Abandoned transaction!"
> } > }
$ pidfile=`pwd`/pidfile $ pidfile=`pwd`/pidfile
$ >$pidfile $ >$pidfile
$ script() { $ script() {
> cat >"$1" > cat >"$1"
> chmod +x "$1" > chmod +x "$1"
$ cat >remote/.hg/hgrc <<EOF $ cat >remote/.hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxnchangegroup.break-things=$hook_script > pretxnchangegroup.break-things=$hook_script
> EOF > EOF
$ cd local $ cd local
$ echo foo > foo ; hg commit -qAm "commit" $ echo foo > foo ; hg commit -qAm "commit"
$ hg push -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd $remotecmd 2>&1 | grep -v $killable_pipe $ hg push -q -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd $remotecmd 2>&1 | grep -v $killable_pipe
pushing to ssh://user@dummy/$TESTTMP/remote
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
abort: stream ended unexpectedly (got 0 bytes, expected 4) abort: stream ended unexpectedly (got 0 bytes, expected 4)
$ check_for_abandoned_transaction $ check_for_abandoned_transaction
[1] [1]