This is an archive of the discontinued Mercurial Phabricator instance.

Differential D961

test-check-code: fail new commits which use 'atexit' instead of 'ui.atexit'
ClosedPublic

Authored by singhsrb on Oct 5 2017, 5:20 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHGb521b3a79afd: test-check-code: fail new commits which use 'atexit' instead of 'ui.atexit'
Summary

Callbacks registered with 'atexit' are sometimes not called (like when
hg aborts and calls os._exit). On the other hand, callbacks registered with
'ui.atexit' are called in most cases. Therefore, encouraging the use of
'ui.atexit' by failing the test 'test-check-code.t' appropriately.

Test Plan

Ran the test 'test-check-code.t' after importing 'atexit' in one of
the py files and confirmed that the test fails.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 5 2017, 5:20 PM
quark accepted this revision.Oct 5 2017, 6:33 PM
Closed by commit rHGb521b3a79afd: test-check-code: fail new commits which use 'atexit' instead of 'ui.atexit' (authored by singhsrb). · Explain WhyOct 7 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (1 line)

Diff 2519

contrib/check-code.py

(r'\bdef\s+__bool__\b', "__bool__ should be __nonzero__ in Python 2"), (r'\bdef\s+__bool__\b', "__bool__ should be __nonzero__ in Python 2"),
(r'os\.path\.join\(.*, *(""|\'\')\)', (r'os\.path\.join\(.*, *(""|\'\')\)',
"use pathutil.normasprefix(path) instead of os.path.join(path, '')"), "use pathutil.normasprefix(path) instead of os.path.join(path, '')"),
(r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'), (r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),
# XXX only catch mutable arguments on the first line of the definition # XXX only catch mutable arguments on the first line of the definition
(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"), (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
(r'\butil\.Abort\b', "directly use error.Abort"), (r'\butil\.Abort\b', "directly use error.Abort"),
(r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"), (r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),
(r'^import atexit', "don't use atexit, use ui.atexit"),
(r'^import Queue', "don't use Queue, use util.queue + util.empty"), (r'^import Queue', "don't use Queue, use util.queue + util.empty"),
(r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"), (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
(r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"), (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
(r'^import SocketServer', "don't use SockerServer, use util.socketserver"), (r'^import SocketServer', "don't use SockerServer, use util.socketserver"),
(r'^import urlparse', "don't use urlparse, use util.urlreq"), (r'^import urlparse', "don't use urlparse, use util.urlreq"),
(r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),
(r'^import cPickle', "don't use cPickle, use util.pickle"), (r'^import cPickle', "don't use cPickle, use util.pickle"),
(r'^import pickle', "don't use pickle, use util.pickle"), (r'^import pickle', "don't use pickle, use util.pickle"),