This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9751

perf: don't turn byte to string when formatting perfbranchmap
ClosedPublic

Authored by marmoute on Jan 13 2021, 11:27 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGcce05a6c271f: perf: don't turn byte to string when formatting perfbranchmap
rHGcdbde70ea705: perf: don't turn byte to string when formatting perfbranchmap
Summary

I am not sure why this str all is there is the first place.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 13 2021, 11:27 AM
marmoute added a commit: rHGcdbde70ea705: perf: don't turn byte to string when formatting perfbranchmap.Jan 13 2021, 2:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGcdbde70ea705: perf: don't turn byte to string when formatting perfbranchmap (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (2 lines)

Diff 24815

contrib/perf.py

branchcacheread.set(lambda *args: None) branchcacheread.set(lambda *args: None)
branchcachewrite = safeattrsetter(branchmap.branchcache, b'write') branchcachewrite = safeattrsetter(branchmap.branchcache, b'write')
branchcachewrite.set(lambda *args: None) branchcachewrite.set(lambda *args: None)
try: try:
for name in allfilters: for name in allfilters:
printname = name printname = name
if name is None: if name is None:
printname = b'unfiltered' printname = b'unfiltered'
timer(getbranchmap(name), title=str(printname)) timer(getbranchmap(name), title=printname)
finally: finally:
branchcacheread.restore() branchcacheread.restore()
branchcachewrite.restore() branchcachewrite.restore()
fm.end() fm.end()
@command( @command(
b'perfbranchmapupdate', b'perfbranchmapupdate',