This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10066

fuzz: if the caller of our makefile sets CC and CXX, trust them
ClosedPublic

Authored by durin42 on Feb 24 2021, 12:41 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG25b1610f8534: fuzz: if the caller of our makefile sets CC and CXX, trust them
Summary

This should fix the broken fuzzing build, because we've been
explicitly using clang++ but are now being given a CXX=afl++, which
does extra stuff.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 24 2021, 12:41 PM
pulkit accepted this revision.Feb 27 2021, 12:19 PM
This revision is now accepted and ready to land.Feb 27 2021, 12:19 PM

Revision Contents
Changeset List

PathPackages
Mcontrib/fuzz/Makefile (4 lines)

Diff 25979

contrib/fuzz/Makefile

CC = clang CC ?= clang
CXX = clang++ CXX ?= clang++
# By default, use our own standalone_fuzz_target_runner. # By default, use our own standalone_fuzz_target_runner.
# This runner does no fuzzing, but simply executes the inputs # This runner does no fuzzing, but simply executes the inputs
# provided via parameters. # provided via parameters.
# Run e.g. "make all LIB_FUZZING_ENGINE=/path/to/libFuzzer.a" # Run e.g. "make all LIB_FUZZING_ENGINE=/path/to/libFuzzer.a"
# to link the fuzzer(s) against a real fuzzing engine. # to link the fuzzer(s) against a real fuzzing engine.
# #
# OSS-Fuzz will define its own value for LIB_FUZZING_ENGINE. # OSS-Fuzz will define its own value for LIB_FUZZING_ENGINE.