Page MenuHomePhabricator

copies-rust: rewrite ChangedFiles binary parsing
ClosedPublic

Authored by SimonSapin on Feb 25 2021, 5:32 AM.

Details

Summary

by using the new from-bytes-safe crate and a custom struct
that encodes the expected data structure.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Feb 25 2021, 5:32 AM
Alphare accepted this revision.Mar 2 2021, 8:36 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
rust/hg-core/src/copy_tracing.rs
165

If you can fix s/hold/holds/ while you're here, that'd be great.

baymax updated this revision to Diff 26020.Mar 2 2021, 9:07 AM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.