This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10081

changelog: rename parameters to reflect semantics
ClosedPublic

Authored by joerg.sonnenberger on Mar 1 2021, 10:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG230f73019e49: changelog: rename parameters to reflect semantics
Summary

read and readfiles can be used with a revision just as well, so
follow the naming convention in revlog to reflect this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joerg.sonnenberger added a commit: rHG230f73019e49: changelog: rename parameters to reflect semantics.Mar 4 2021, 7:39 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG230f73019e49: changelog: rename parameters to reflect semantics (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (8 lines)

Diff 26066

mercurial/changelog.py

return True return True
return False return False
def _enforceinlinesize(self, tr, fp=None): def _enforceinlinesize(self, tr, fp=None):
if not self._delayed: if not self._delayed:
revlog.revlog._enforceinlinesize(self, tr, fp) revlog.revlog._enforceinlinesize(self, tr, fp)
def read(self, node): def read(self, nodeorrev):
"""Obtain data from a parsed changelog revision. """Obtain data from a parsed changelog revision.
Returns a 6-tuple of: Returns a 6-tuple of:
- manifest node in binary - manifest node in binary
- author/user as a localstr - author/user as a localstr
- date as a 2-tuple of (time, timezone) - date as a 2-tuple of (time, timezone)
- list of files - list of files
- commit message as a localstr - commit message as a localstr
- dict of extra metadata - dict of extra metadata
Unless you need to access all fields, consider calling Unless you need to access all fields, consider calling
``changelogrevision`` instead, as it is faster for partial object ``changelogrevision`` instead, as it is faster for partial object
access. access.
""" """
d, s = self._revisiondata(node) d, s = self._revisiondata(nodeorrev)
c = changelogrevision( c = changelogrevision(
d, s, self._copiesstorage == b'changeset-sidedata' d, s, self._copiesstorage == b'changeset-sidedata'
) )
return (c.manifest, c.user, c.date, c.files, c.description, c.extra) return (c.manifest, c.user, c.date, c.files, c.description, c.extra)
def changelogrevision(self, nodeorrev): def changelogrevision(self, nodeorrev):
"""Obtain a ``changelogrevision`` for a node or revision.""" """Obtain a ``changelogrevision`` for a node or revision."""
text, sidedata = self._revisiondata(nodeorrev) text, sidedata = self._revisiondata(nodeorrev)
return changelogrevision( return changelogrevision(
text, sidedata, self._copiesstorage == b'changeset-sidedata' text, sidedata, self._copiesstorage == b'changeset-sidedata'
) )
def readfiles(self, node): def readfiles(self, nodeorrev):
""" """
short version of read that only returns the files modified by the cset short version of read that only returns the files modified by the cset
""" """
text = self.revision(node) text = self.revision(nodeorrev)
if not text: if not text:
return [] return []
last = text.index(b"\n\n") last = text.index(b"\n\n")
l = text[:last].split(b'\n') l = text[:last].split(b'\n')
return l[3:] return l[3:]
def add( def add(
self, self,