Page MenuHomePhabricator

dispatch: use detailed exit code 250 for keyboard interrupt
ClosedPublic

Authored by martinvonz on Mar 1 2021, 5:56 PM.

Details

Summary

Among our users at Google, we're still seeing several percent of
commands fail with exit code 255. I suspect keyboard interrupts is an
important remaining reason.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 1 2021, 5:56 PM
pulkit accepted this revision.Mar 2 2021, 4:02 AM
This revision is now accepted and ready to land.Mar 2 2021, 4:02 AM

This broke test-chg.t on py2 because the exit code changed from 255 to 250. However, the problem is that it didn't break the test on py3. I'll have to figure out how to get the right exit code on py3 as well. I've dropped the commit for now.