( )⚙ D10126 typing: add some type annotations to mercurial/phases.py

This is an archive of the discontinued Mercurial Phabricator instance.

typing: add some type annotations to mercurial/phases.py
ClosedPublic

Authored by mharbison72 on Mar 6 2021, 7:46 PM.

Details

Summary

Some of these were helpful in typing other modules, and then I typed the
easy-ish ones. Black forces the long Phasedefaults definition to be wrapped,
which pytype seems OK with (as shown with reveal_type()), but it does seem to
confuse PyCharm a bit.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Mar 6 2021, 7:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.