( )⚙ D10257 rebase: set `prepared = True` at very end of `_preparenewrebase()`

This is an archive of the discontinued Mercurial Phabricator instance.

rebase: set `prepared = True` at very end of `_preparenewrebase()`
ClosedPublic

Authored by martinvonz on Mar 24 2021, 2:25 AM.

Details

Summary

Once we've set rebaseruntime.prepared = True, rebaseruntime.repo
starts returning the unfiltered repo. That will make my next patch
break, because that patch moves the call to rewriteutil.precheck()
after the call to _handleskippingobsolete(), which current happens
after prepared = True. We therefore need to prepare by moving
prepared = True a bit later, after _handleskippingobsolete(). I
don't think that matters for that call.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Mar 24 2021, 2:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.