Page MenuHomePhabricator

re2: adjust local variable assignment scope
ClosedPublic

Authored by mharbison72 on Tue, Apr 13, 12:02 AM.

Details

Summary

Pytype flagged the exception handler where these are used as [name-error], and
PyCharm complained they may be used before assignment.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Tue, Apr 13, 12:02 AM

The commit this fixes is on stable, but since the test to run pytype is on default, it probably doesn't matter where it goes.

pulkit accepted this revision.Tue, Apr 13, 8:54 AM
This revision is now accepted and ready to land.Tue, Apr 13, 8:54 AM
This revision was automatically updated to reflect the committed changes.