This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10466

errors: introduce a class for remote errors
ClosedPublic

Authored by martinvonz on Apr 19 2021, 4:04 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf9482db16cef: errors: introduce a class for remote errors
rHGdd1c45615e35: errors: introduce a class for remote errors
Summary

Having an exception for remote errors makes it much easier to exit
with the right detailed exit code.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 19 2021, 4:04 PM
martinvonz added a commit: rHGdd1c45615e35: errors: introduce a class for remote errors.Apr 19 2021, 11:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGdd1c45615e35: errors: introduce a class for remote errors (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/error.py (6 lines)
Mmercurial/scmutil.py (2 lines)

Diff 27065

mercurial/error.py

"""Raised when an EOF is received for a prompt""" """Raised when an EOF is received for a prompt"""
def __init__(self): def __init__(self):
from .i18n import _ from .i18n import _
Abort.__init__(self, _(b'response expected')) Abort.__init__(self, _(b'response expected'))
class OutOfBandError(Abort): class RemoteError(Abort):
"""Exception raised when interacting with a remote repo fails"""
class OutOfBandError(RemoteError):
"""Exception raised when a remote repo reports failure""" """Exception raised when a remote repo reports failure"""
def __init__(self, *messages, hint=None): def __init__(self, *messages, hint=None):
# type: (Any, Optional[bytes]) -> None # type: (Any, Optional[bytes]) -> None
from .i18n import _ from .i18n import _
if messages: if messages:
message = _(b"remote error:\n%s") % b''.join(messages) message = _(b"remote error:\n%s") % b''.join(messages)

mercurial/scmutil.py

if isinstance(inst, (error.InputError, error.ParseError)): if isinstance(inst, (error.InputError, error.ParseError)):
detailed_exit_code = 10 detailed_exit_code = 10
elif isinstance(inst, error.StateError): elif isinstance(inst, error.StateError):
detailed_exit_code = 20 detailed_exit_code = 20
elif isinstance(inst, error.ConfigError): elif isinstance(inst, error.ConfigError):
detailed_exit_code = 30 detailed_exit_code = 30
elif isinstance(inst, error.HookAbort): elif isinstance(inst, error.HookAbort):
detailed_exit_code = 40 detailed_exit_code = 40
elif isinstance(inst, error.OutOfBandError): elif isinstance(inst, error.RemoteError):
detailed_exit_code = 100 detailed_exit_code = 100
elif isinstance(inst, error.SecurityError): elif isinstance(inst, error.SecurityError):
detailed_exit_code = 150 detailed_exit_code = 150
elif isinstance(inst, error.CanceledError): elif isinstance(inst, error.CanceledError):
detailed_exit_code = 250 detailed_exit_code = 250
ui.error(inst.format()) ui.error(inst.format())
except error.WorkerError as inst: except error.WorkerError as inst:
# Don't print a message -- the worker already should have # Don't print a message -- the worker already should have