This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10472

tests: make test-archive.t pass on py3.9 (issue6504)
ClosedPublic

Authored by martinvonz on Apr 19 2021, 7:55 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdc8976cc3a6e: tests: make test-archive.t pass on py3.9 (issue6504)
rHGe485e4c55901: tests: make test-archive.t pass on py3.9 (issue6504)
Summary

Something got stricter at parsing URL query parameters and now the
parameters need to be separated by "&"; ";" is no longer allowed. See
issue6504 for details.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Apr 19 2021, 7:55 PM
martinvonz retitled this revision from tests: make test-archive.t pass on py3.9 to tests: make test-archive.t pass on py3.9 (issue6504).Apr 19 2021, 11:06 PM
martinvonz edited the summary of this revision. (Show Details)
martinvonz added a commit: rHGe485e4c55901: tests: make test-archive.t pass on py3.9 (issue6504).Apr 19 2021, 11:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGe485e4c55901: tests: make test-archive.t pass on py3.9 (issue6504) (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-archive.t (4 lines)

Diff 27061

tests/test-archive.t

> try: > try:
> # Set stdout to binary mode for win32 platforms > # Set stdout to binary mode for win32 platforms
> import msvcrt > import msvcrt
> msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY) > msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
> except ImportError: > except ImportError:
> pass > pass
> if len(sys.argv) <= 3: > if len(sys.argv) <= 3:
> node, archive = sys.argv[1:] > node, archive = sys.argv[1:]
> requeststr = 'cmd=archive;node=%s;type=%s' % (node, archive) > requeststr = 'cmd=archive&node=%s&type=%s' % (node, archive)
> else: > else:
> node, archive, file = sys.argv[1:] > node, archive, file = sys.argv[1:]
> requeststr = 'cmd=archive;node=%s;type=%s;file=%s' % (node, archive, file) > requeststr = 'cmd=archive&node=%s&type=%s&file=%s' % (node, archive, file)
> try: > try:
> stdout = sys.stdout.buffer > stdout = sys.stdout.buffer
> except AttributeError: > except AttributeError:
> stdout = sys.stdout > stdout = sys.stdout
> try: > try:
> f = util.urlreq.urlopen('http://$LOCALIP:%s/?%s' > f = util.urlreq.urlopen('http://$LOCALIP:%s/?%s'
> % (os.environ['HGPORT'], requeststr)) > % (os.environ['HGPORT'], requeststr))
> stdout.write(f.read()) > stdout.write(f.read())