This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10743

rust: Fix "panic message is not a string literal" warnings
ClosedPublic

Authored by SimonSapin on May 19 2021, 9:22 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG16b48ebf656e: rust: Fix "panic message is not a string literal" warnings
rHG4d18a5606a03: rust: Fix "panic message is not a string literal" warnings
rHG21e9ff96a811: rust: Fix "panic message is not a string literal" warnings
Summary

These deprecation warnings would not become errors until we actively port
crates to the (not yet released) Rust 2021 edition, but fixing them anyway
reduces console output noise.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 28128

rust/hg-core/tests/test_missing_ancestors.rs

fn assert_eq<T>(&self, left: T, right: T) fn assert_eq<T>(&self, left: T, right: T)
where where
T: PartialEq + Debug, T: PartialEq + Debug,
{ {
if left == right { if left == right {
return; return;
} }
panic!(format!( panic!(
"Equality assertion failed (left != right) "Equality assertion failed (left != right)
left={:?} left={:?}
right={:?} right={:?}
graph={:?} graph={:?}
current bases={:?} current bases={:?}
history={:?} history={:?}
random seed={} random seed={}
", ",
left, left,
right, right,
self.graph, self.graph,
self.bases, self.bases,
self.history, self.history,
self.random_seed, self.random_seed,
)); );
} }
} }
/// Choose a set of random revisions /// Choose a set of random revisions
/// ///
/// The size of the set is taken from a LogNormal distribution /// The size of the set is taken from a LogNormal distribution
/// with default mu=1.1 and default sigma=0.8. Quoting the Python /// with default mu=1.1 and default sigma=0.8. Quoting the Python
/// test this is taken from: /// test this is taken from:
/// Returns (graphs, instances, calls per instance) /// Returns (graphs, instances, calls per instance)
fn parse_test_missing_ancestors_params(var: &str) -> (usize, usize, usize) { fn parse_test_missing_ancestors_params(var: &str) -> (usize, usize, usize) {
let err_msg = "TEST_MISSING_ANCESTORS format: GRAPHS,INSTANCES,CALLS"; let err_msg = "TEST_MISSING_ANCESTORS format: GRAPHS,INSTANCES,CALLS";
let params: Vec<usize> = var let params: Vec<usize> = var
.split(',') .split(',')
.map(|n| n.trim().parse().expect(err_msg)) .map(|n| n.trim().parse().expect(err_msg))
.collect(); .collect();
if params.len() != 3 { if params.len() != 3 {
panic!(err_msg); panic!("{}", err_msg);
} }
(params[0], params[1], params[2]) (params[0], params[1], params[2])
} }
#[test] #[test]
/// This test creates lots of random VecGraphs, /// This test creates lots of random VecGraphs,
/// and compare a bunch of MissingAncestors for them with /// and compare a bunch of MissingAncestors for them with
/// NaiveMissingAncestors that rely on precomputed transitive closures of /// NaiveMissingAncestors that rely on precomputed transitive closures of