This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10820

verify: use some intermediate variables instead of a multi-liner
ClosedPublic

Authored by marmoute on Jun 1 2021, 5:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1a0f177b300a: verify: use some intermediate variables instead of a multi-liner
Summary

This is shorter and easier to read as the indentation remains the same.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jun 1 2021, 5:55 AM
marmoute added a commit: rHG1a0f177b300a: verify: use some intermediate variables instead of a multi-liner.Jun 1 2021, 3:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG1a0f177b300a: verify: use some intermediate variables instead of a multi-liner (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/verify.py (11 lines)

Diff 28377

mercurial/verify.py

rp = fl.renamed(n) rp = fl.renamed(n)
if rp: if rp:
if lr is not None and ui.verbose: if lr is not None and ui.verbose:
ctx = lrugetctx(lr) ctx = lrugetctx(lr)
if not any(rp[0] in pctx for pctx in ctx.parents()): if not any(rp[0] in pctx for pctx in ctx.parents()):
self._warn(WARN_UNKNOWN_COPY_SOURCE % (f, ctx)) self._warn(WARN_UNKNOWN_COPY_SOURCE % (f, ctx))
fl2 = repo.file(rp[0]) fl2 = repo.file(rp[0])
if not len(fl2): if not len(fl2):
self._err( m = _(b"empty or missing copy source revlog %s:%s")
lr, self._err(lr, m % (rp[0], short(rp[1])), f)
_(
b"empty or missing copy source revlog "
b"%s:%s"
)
% (rp[0], short(rp[1])),
f,
)
elif rp[1] == self.repo.nullid: elif rp[1] == self.repo.nullid:
ui.note( ui.note(
_( _(
b"warning: %s@%s: copy source" b"warning: %s@%s: copy source"
b" revision is nullid %s:%s\n" b" revision is nullid %s:%s\n"
) )
% (f, lr, rp[0], short(rp[1])) % (f, lr, rp[0], short(rp[1]))
) )