This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1115

test-clang-format: new test to verify that files stay clang-formatted
ClosedPublic

Authored by durin42 on Oct 16 2017, 11:53 AM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG8d2cada7277d: test-clang-format: new test to verify that files stay clang-formatted

Summary

For now all .c and .h files are blacklisted. As they become
clang-formatted, we'll remove them from the blacklist,and then this
test will produce output if there are diffs.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2017, 11:53 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 16 2017, 11:53 AM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

durin42 added a child revision: D1116: Makefile: add target to apply clang-format in-place.Oct 16 2017, 11:53 AM

Closed by commit rHG8d2cada7277d: test-clang-format: new test to verify that files stay clang-formatted (authored by durin42). · Explain WhyOct 16 2017, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		contrib/clang-format-blacklist (70 lines)
A	M		tests/test-check-clang-format.t (7 lines)

Status	Author	Revision
Closed	durin42	D1032 exewrapper: format with clang-format
Closed	durin42	D1031 util: add clang-format control comment around struct and format macro
Closed	durin42	D1116 Makefile: add target to apply clang-format in-place
Closed	durin42	D1115 test-clang-format: new test to verify that files stay clang-formatted
Closed	durin42	D1030 mpatch: switch alignment of wrapped line from tab to spaces with clang-format
Closed	durin42	D1029 mpatch: reflow two oddly formatted else blocks with clang-format
Closed	durin42	D1028 mpatch: reformat function prototypes with clang-format
Closed	durin42	D1027 mpatch: re-wrap wide line with clang-format

Diff 2858

contrib/clang-format-blacklist

This file was added.

				# Files that just need to be migrated to the formatter.
				# Do not add new files here!
				contrib/chg/chg.c
				contrib/chg/hgclient.c
				contrib/chg/hgclient.h
				contrib/chg/procutil.c
				contrib/chg/procutil.h
				contrib/chg/util.c
				contrib/chg/util.h
				contrib/hgsh/hgsh.c
				mercurial/cext/base85.c
				mercurial/cext/bdiff.c
				mercurial/cext/charencode.c
				mercurial/cext/charencode.h
				mercurial/cext/diffhelpers.c
				mercurial/cext/dirs.c
				mercurial/cext/manifest.c
				mercurial/cext/mpatch.c
				mercurial/cext/osutil.c
				mercurial/cext/parsers.c
				mercurial/cext/pathencode.c
				mercurial/cext/revlog.c
				# Vendored code that we should never format:
				contrib/python-zstandard/c-ext/bufferutil.c
				contrib/python-zstandard/c-ext/compressiondict.c
				contrib/python-zstandard/c-ext/compressionparams.c
				contrib/python-zstandard/c-ext/compressionwriter.c
				contrib/python-zstandard/c-ext/compressobj.c
				contrib/python-zstandard/c-ext/compressor.c
				contrib/python-zstandard/c-ext/compressoriterator.c
				contrib/python-zstandard/c-ext/constants.c
				contrib/python-zstandard/c-ext/decompressionwriter.c
				contrib/python-zstandard/c-ext/decompressobj.c
				contrib/python-zstandard/c-ext/decompressor.c
				contrib/python-zstandard/c-ext/decompressoriterator.c
				contrib/python-zstandard/c-ext/frameparams.c
				contrib/python-zstandard/c-ext/python-zstandard.h
				contrib/python-zstandard/zstd.c
				contrib/python-zstandard/zstd/common/bitstream.h
				contrib/python-zstandard/zstd/common/entropy_common.c
				contrib/python-zstandard/zstd/common/error_private.c
				contrib/python-zstandard/zstd/common/error_private.h
				contrib/python-zstandard/zstd/common/fse.h
				contrib/python-zstandard/zstd/common/fse_decompress.c
				contrib/python-zstandard/zstd/common/huf.h
				contrib/python-zstandard/zstd/common/mem.h
				contrib/python-zstandard/zstd/common/pool.c
				contrib/python-zstandard/zstd/common/pool.h
				contrib/python-zstandard/zstd/common/threading.c
				contrib/python-zstandard/zstd/common/threading.h
				contrib/python-zstandard/zstd/common/xxhash.c
				contrib/python-zstandard/zstd/common/xxhash.h
				contrib/python-zstandard/zstd/common/zstd_common.c
				contrib/python-zstandard/zstd/common/zstd_errors.h
				contrib/python-zstandard/zstd/common/zstd_internal.h
				contrib/python-zstandard/zstd/compress/fse_compress.c
				contrib/python-zstandard/zstd/compress/huf_compress.c
				contrib/python-zstandard/zstd/compress/zstd_compress.c
				contrib/python-zstandard/zstd/compress/zstd_opt.h
				contrib/python-zstandard/zstd/compress/zstdmt_compress.c
				contrib/python-zstandard/zstd/compress/zstdmt_compress.h
				contrib/python-zstandard/zstd/decompress/huf_decompress.c
				contrib/python-zstandard/zstd/decompress/zstd_decompress.c
				contrib/python-zstandard/zstd/dictBuilder/cover.c
				contrib/python-zstandard/zstd/dictBuilder/divsufsort.c
				contrib/python-zstandard/zstd/dictBuilder/divsufsort.h
				contrib/python-zstandard/zstd/dictBuilder/zdict.c
				contrib/python-zstandard/zstd/dictBuilder/zdict.h
				contrib/python-zstandard/zstd/zstd.h
				hgext/fsmonitor/pywatchman/bser.c

tests/test-check-clang-format.t

This file was added.

				#require clang-format test-repo
				$ cd "$TESTDIR"/..
				$ for f in `hg files 'set:(.c or .h) and not "listfile:contrib/clang-format-blacklist"'` ; do
				> clang-format --style file $f > $f.formatted
				> cmp $f $f.formatted \|\| diff -u $f $f.formatted
				> rm $f.formatted
				> done

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	2824		Oct 16 2017, 11:53 AM	★	★
Diff 2	2858	rHG8d2cada7277db71c2f1772d238e9b2eb2908bef8	Sep 14 2015, 2:17 PM	★	★