This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1030

mpatch: switch alignment of wrapped line from tab to spaces with clang-format
ClosedPublic

Authored by durin42 on Oct 12 2017, 11:09 AM.

Details

Reviewers
pulkit
ryanmce
Group Reviewers
hg-reviewers
Commits
rHG3b9e510335ee: mpatch: switch alignment of wrapped line from tab to spaces with clang-format
Summary

I may be a weird person for liking this style, but our C style is
historically nominally the Linux Kernel style, and when you configure
clang-format to be kernel-ish, this is what you get. If we want to
change it, we can do so by tweaking the formatter rules in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 12 2017, 11:09 AM
pulkit accepted this revision.Oct 12 2017, 2:46 PM
pulkit added a subscriber: pulkit.

Those who are struggling seeing the diff here or in similar cases, click on History tab which is next to File one, just under the Revision content on this page and you will "Whitespace change" thing in the right and change it to show all. :)

ryanmce requested changes to this revision.Oct 13 2017, 1:42 PM
ryanmce added a subscriber: ryanmce.

Seems like we should figure out the spacing stuff on D1028 before moving forward here.

This revision now requires changes to proceed.Oct 13 2017, 1:42 PM
Closed by commit rHG3b9e510335ee: mpatch: switch alignment of wrapped line from tab to spaces with clang-format (authored by durin42). · Explain WhyOct 16 2017, 9:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/mpatch.c (2 lines)

Diff 2857

mercurial/mpatch.c

if (start + 1 == end) { if (start + 1 == end) {
/* trivial case, output a decoded list */ /* trivial case, output a decoded list */
return get_next_item(bins, start); return get_next_item(bins, start);
} }
/* divide and conquer, memory management is elsewhere */ /* divide and conquer, memory management is elsewhere */
len = (end - start) / 2; len = (end - start) / 2;
return combine(mpatch_fold(bins, get_next_item, start, start + len), return combine(mpatch_fold(bins, get_next_item, start, start + len),
mpatch_fold(bins, get_next_item, start + len, end)); mpatch_fold(bins, get_next_item, start + len, end));
} }