This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11215

test-transaction-safety: document the test schedule
ClosedPublic

Authored by marmoute on Jul 27 2021, 9:09 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4870a8dc24d9: test-transaction-safety: document the test schedule
Summary

This helps reader to understand how the test work and actually helped me to
detect a missing synchronisation step.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 27 2021, 9:09 AM
marmoute added a commit: rHG4870a8dc24d9: test-transaction-safety: document the test schedule.Jul 30 2021, 11:22 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG4870a8dc24d9: test-transaction-safety: document the test schedule (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-transaction-safety.t (19 lines)

Diff 29759

tests/test-transaction-safety.t

# TODO: also add an external reader accessing revlog files while they are written # TODO: also add an external reader accessing revlog files while they are written
# (instead of during transaction finalisation) # (instead of during transaction finalisation)
# TODO: also add stream clone and hardlink clone happening during these transaction. # TODO: also add stream clone and hardlink clone happening during these transaction.
setup setup
----- -----
synchronisation+output script: synchronisation+output script using the following schedule:
[A1] "external" is started
[A2] "external" waits on EXT_UNLOCK
[A2] "external" + creates EXT_WAITING → unlocks [C1]
[B1] "hg commit/pull" is started
[B2] "hg commit/pull" is ready to be committed
[B3] "hg commit/pull" spawn "internal" using a pretxnclose hook (need [C4])
[C1] "internal" waits on EXT_WAITING (need [A2])
[C2] "internal" show the tipmost revision (inside of the transaction)
[C3] "internal" waits on EXT_DONE (need [A4])
[C3] "internal" + creates EXT_UNLOCK → unlocks [A2]
[A3] "external" show the tipmost revision (outside of the transaction)
[A4] "external" creates EXT_DONE → unlocks [C3]
[C4] "internal" end of execution -> unlock [B3]
[B4] "hg commit/pull" transaction is committed on disk
$ mkdir sync $ mkdir sync
$ mkdir output $ mkdir output
$ mkdir script $ mkdir script
$ HG_TEST_FILE_EXT_WAITING=$TESTTMP/sync/ext_waiting $ HG_TEST_FILE_EXT_WAITING=$TESTTMP/sync/ext_waiting
$ export HG_TEST_FILE_EXT_WAITING $ export HG_TEST_FILE_EXT_WAITING
$ HG_TEST_FILE_EXT_UNLOCK=$TESTTMP/sync/ext_unlock $ HG_TEST_FILE_EXT_UNLOCK=$TESTTMP/sync/ext_unlock
$ export HG_TEST_FILE_EXT_UNLOCK $ export HG_TEST_FILE_EXT_UNLOCK
$ HG_TEST_FILE_EXT_DONE=$TESTTMP/sync/ext_done $ HG_TEST_FILE_EXT_DONE=$TESTTMP/sync/ext_done
$ export HG_TEST_FILE_EXT_DONE $ export HG_TEST_FILE_EXT_DONE
$ cat << EOF > script/external.sh $ cat << EOF > script/external.sh
> #!/bin/sh > #!/bin/sh
> "$RUNTESTDIR/testlib/wait-on-file" 5 "$HG_TEST_FILE_EXT_UNLOCK" "$HG_TEST_FILE_EXT_WAITING" > "$RUNTESTDIR/testlib/wait-on-file" 5 "$HG_TEST_FILE_EXT_UNLOCK" "$HG_TEST_FILE_EXT_WAITING"
> hg log --rev 'tip' -T 'external: {rev} {desc}\n' > "$TESTTMP/output/external.out" > hg log --rev 'tip' -T 'external: {rev} {desc}\n' > "$TESTTMP/output/external.out"
> touch "$HG_TEST_FILE_EXT_DONE" > touch "$HG_TEST_FILE_EXT_DONE"
> EOF > EOF
$ cat << EOF > script/internal.sh $ cat << EOF > script/internal.sh
> #!/bin/sh > #!/bin/sh
> "$RUNTESTDIR/testlib/wait-on-file" 5 "$HG_TEST_FILE_EXT_WAITING"
> hg log --rev 'tip' -T 'internal: {rev} {desc}\n' > "$TESTTMP/output/internal.out" > hg log --rev 'tip' -T 'internal: {rev} {desc}\n' > "$TESTTMP/output/internal.out"
> "$RUNTESTDIR/testlib/wait-on-file" 5 "$HG_TEST_FILE_EXT_DONE" "$HG_TEST_FILE_EXT_UNLOCK" > "$RUNTESTDIR/testlib/wait-on-file" 5 "$HG_TEST_FILE_EXT_DONE" "$HG_TEST_FILE_EXT_UNLOCK"
> EOF > EOF
Automated commands: Automated commands:
$ make_one_commit() { $ make_one_commit() {