( )⚙ D11226 run-tests: do not inherit file descriptor when running a command

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11226

run-tests: do not inherit file descriptor when running a command
ClosedPublic

Authored by marmoute on Jul 28 2021, 10:58 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGc405c089611a: run-tests: do not inherit file descriptor when running a command
Summary

This is one of the difference between python2 and python3 and could have been a
reason why test hang with python2 + chg. This does not seems to help the
hanging issue at all…

However, now that this is written lets reduce the difference between python2
and python3.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 28 2021, 10:58 AM
marmoute added a commit: rHGc405c089611a: run-tests: do not inherit file descriptor when running a command.Jul 30 2021, 11:11 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGc405c089611a: run-tests: do not inherit file descriptor when running a command (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (1 line)

Diff 29733

tests/run-tests.py

stderr). stderr).
Return a tuple (exitcode, output). output is None in debug mode. Return a tuple (exitcode, output). output is None in debug mode.
""" """
if self._debug: if self._debug:
proc = subprocess.Popen( proc = subprocess.Popen(
_bytes2sys(cmd), _bytes2sys(cmd),
shell=True, shell=True,
close_fds=closefds,
cwd=_bytes2sys(self._testtmp), cwd=_bytes2sys(self._testtmp),
env=env, env=env,
) )
ret = proc.wait() ret = proc.wait()
return (ret, None) return (ret, None)
proc = Popen4(cmd, self._testtmp, self._timeout, env) proc = Popen4(cmd, self._testtmp, self._timeout, env)