This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11227

run-tests: use a small timeout for chg instance
ClosedPublic

Authored by marmoute on Jul 28 2021, 10:58 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG036b9b3cc79a: run-tests: use a small timeout for chg instance
Summary

There is case where the test runner fails to clean up the temporary files in
that case, spawned chg instance can stay around for 1 hours. Getting them to
shut down sooner cannot hurt.

(We should also use a more robust approach for this cleanup)

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 28 2021, 10:58 AM
marmoute added a commit: rHG036b9b3cc79a: run-tests: use a small timeout for chg instance.Jul 30 2021, 11:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG036b9b3cc79a: run-tests: use a small timeout for chg instance (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)
Mtests/test-basic.t (1 line)
Mtests/test-commandserver.t (1 line)

Diff 29734

tests/run-tests.py

hgrc.write(b'[ui]\n') hgrc.write(b'[ui]\n')
hgrc.write(b'slash = True\n') hgrc.write(b'slash = True\n')
hgrc.write(b'interactive = False\n') hgrc.write(b'interactive = False\n')
hgrc.write(b'detailed-exit-code = True\n') hgrc.write(b'detailed-exit-code = True\n')
hgrc.write(b'merge = internal:merge\n') hgrc.write(b'merge = internal:merge\n')
hgrc.write(b'mergemarkers = detailed\n') hgrc.write(b'mergemarkers = detailed\n')
hgrc.write(b'promptecho = True\n') hgrc.write(b'promptecho = True\n')
hgrc.write(b'timeout.warn=15\n') hgrc.write(b'timeout.warn=15\n')
hgrc.write(b'[chgserver]\n')
hgrc.write(b'idletimeout=60\n')
hgrc.write(b'[defaults]\n') hgrc.write(b'[defaults]\n')
hgrc.write(b'[devel]\n') hgrc.write(b'[devel]\n')
hgrc.write(b'all-warnings = true\n') hgrc.write(b'all-warnings = true\n')
hgrc.write(b'default-date = 0 0\n') hgrc.write(b'default-date = 0 0\n')
hgrc.write(b'[largefiles]\n') hgrc.write(b'[largefiles]\n')
hgrc.write( hgrc.write(
b'usercache = %s\n' b'usercache = %s\n'
% (os.path.join(self._testtmp, b'.cache/largefiles')) % (os.path.join(self._testtmp, b'.cache/largefiles'))

tests/test-basic.t

Create a repository: Create a repository:
#if no-extraextensions #if no-extraextensions
$ hg config $ hg config
chgserver.idletimeout=60
devel.all-warnings=true devel.all-warnings=true
devel.default-date=0 0 devel.default-date=0 0
extensions.fsmonitor= (fsmonitor !) extensions.fsmonitor= (fsmonitor !)
format.exp-dirstate-v2=1 (dirstate-v2 !) format.exp-dirstate-v2=1 (dirstate-v2 !)
largefiles.usercache=$TESTTMP/.cache/largefiles largefiles.usercache=$TESTTMP/.cache/largefiles
lfs.usercache=$TESTTMP/.cache/lfs lfs.usercache=$TESTTMP/.cache/lfs
ui.slash=True ui.slash=True
ui.interactive=False ui.interactive=False

tests/test-commandserver.t

... # show it ... # show it
... runcommand(server, [b'showconfig'], outfilter=sep) ... runcommand(server, [b'showconfig'], outfilter=sep)
... ...
... # but not for this repo ... # but not for this repo
... runcommand(server, [b'init', b'foo']) ... runcommand(server, [b'init', b'foo'])
... runcommand(server, [b'-R', b'foo', b'showconfig', b'ui', b'defaults']) ... runcommand(server, [b'-R', b'foo', b'showconfig', b'ui', b'defaults'])
*** runcommand showconfig *** runcommand showconfig
bundle.mainreporoot=$TESTTMP/repo bundle.mainreporoot=$TESTTMP/repo
chgserver.idletimeout=60
devel.all-warnings=true devel.all-warnings=true
devel.default-date=0 0 devel.default-date=0 0
extensions.fsmonitor= (fsmonitor !) extensions.fsmonitor= (fsmonitor !)
format.exp-dirstate-v2=1 (dirstate-v2 !) format.exp-dirstate-v2=1 (dirstate-v2 !)
largefiles.usercache=$TESTTMP/.cache/largefiles largefiles.usercache=$TESTTMP/.cache/largefiles
lfs.usercache=$TESTTMP/.cache/lfs lfs.usercache=$TESTTMP/.cache/lfs
ui.slash=True ui.slash=True
ui.interactive=False ui.interactive=False