This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11257

pager: account for flakiness in Windows output
ClosedPublic

Authored by Alphare on Aug 5 2021, 12:26 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbc74cb9a8e40: pager: account for flakiness in Windows output
rHG570cbb3dc65e: pager: account for flakiness in Windows output
rHG89f64fd17f45: pager: account for flakiness in Windows output
Summary

This test case is cursed and probably not worth losing more time over. This
makes apparent what the intended behavior is while still removing the flakiness
from the CI.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Aug 5 2021, 12:26 PM
Alphare added a commit: rHG89f64fd17f45: pager: account for flakiness in Windows output.Aug 5 2021, 12:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG89f64fd17f45: pager: account for flakiness in Windows output (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 29817.Aug 5 2021, 1:31 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Alphare added a comment.Aug 6 2021, 8:50 AM

Looks like I forgot the last (?) (for the last "empty" line), I'll amend the changeset.

Revision Contents
Changeset List

PathPackages
Mtests/test-pager.t (32 lines)

Diff 29810

tests/test-pager.t

\x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc) \x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc)
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: modify a 8 summary: modify a 8
#endif #endif
A complicated pager command gets worse behavior. Bonus points if you can A complicated pager command gets worse behavior. Bonus points if you can
improve this. Windows apparently does this better? improve this. Windows apparently does this better, but only sometimes?
#if windows #if windows
$ hg log --limit 3 \ $ hg log --limit 3 \
> --config pager.pager='this-command-better-never-exist --seriously' \ > --config pager.pager='this-command-better-never-exist --seriously' \
> 2>/dev/null || true > 2>/dev/null || true
\x1b[0;33mchangeset: 10:46106edeeb38\x1b[0m (esc) \x1b[0;33mchangeset: 10:46106edeeb38\x1b[0m (esc) (?)
tag: tip tag: tip (?)
user: test user: test (?)
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000 (?)
summary: modify a 10 summary: modify a 10 (?)
(?)
\x1b[0;33mchangeset: 9:6dd8ea7dd621\x1b[0m (esc) \x1b[0;33mchangeset: 9:6dd8ea7dd621\x1b[0m (esc) (?)
user: test user: test (?)
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000 (?)
summary: modify a 9 summary: modify a 9 (?)
(?)
\x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc) \x1b[0;33mchangeset: 8:cff05a6312fe\x1b[0m (esc) (?)
user: test user: test (?)
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000 (?)
summary: modify a 8 summary: modify a 8 (?)
#else #else
$ hg log --limit 3 \ $ hg log --limit 3 \
> --config pager.pager='this-command-better-never-exist --seriously' \ > --config pager.pager='this-command-better-never-exist --seriously' \
> 2>/dev/null || true > 2>/dev/null || true
#endif #endif
Pager works with shell aliases. Pager works with shell aliases.