( )⚙ D11258 heptapod-ci: extend timeout for pytype checking

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11258

heptapod-ci: extend timeout for pytype checking
ClosedPublic

Authored by Alphare on Aug 5 2021, 12:38 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG3712c0ee9e9c: heptapod-ci: extend timeout for pytype checking
Summary

This test routinely times out for loaded or older machines.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Aug 5 2021, 12:38 PM
marmoute requested changes to this revision.Aug 5 2021, 1:11 PM
marmoute added a subscriber: marmoute.

I don't know what you are trying to do, --slowtimeout takes an argument and is probably not the flag you are looking for. Your best bet et probably to extend the timeout through the variable defined at the project level.

This revision now requires changes to proceed.Aug 5 2021, 1:11 PM
Alphare updated this revision to Diff 29822.Aug 6 2021, 3:27 AM
Alphare added a comment.Aug 6 2021, 3:28 AM

I appear to have misunderstood the help text. I want to extend the timeout of the individual test, not the CI's. I've updated the patch with what I'm assuming works?

marmoute requested changes to this revision.Aug 6 2021, 5:38 AM
In D11258#172834, @Alphare wrote:

I appear to have misunderstood the help text. I want to extend the timeout of the individual test, not the CI's. I've updated the patch with what I'm assuming works?

the CI is already adding an using an environment variable to extend the timeout. By using an explicit value here, you are bypassing this mechanism and might end up -lowering- the timeout in practice.

This revision now requires changes to proceed.Aug 6 2021, 5:38 AM
Alphare updated this revision to Diff 29823.Aug 6 2021, 5:47 AM
marmoute accepted this revision.Aug 6 2021, 5:50 AM

This isn't great, but this will do for now.

Alphare added a commit: rHG3712c0ee9e9c: heptapod-ci: extend timeout for pytype checking.Aug 18 2021, 12:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3712c0ee9e9c: heptapod-ci: extend timeout for pytype checking (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/heptapod-ci.yml (2 lines)

Diff 29822

contrib/heptapod-ci.yml

extends: .runtests_template extends: .runtests_template
before_script: before_script:
- hg clone . /tmp/mercurial-ci/ --noupdate --config phases.publish=no - hg clone . /tmp/mercurial-ci/ --noupdate --config phases.publish=no
- hg -R /tmp/mercurial-ci/ update `hg log --rev '.' --template '{node}'` - hg -R /tmp/mercurial-ci/ update `hg log --rev '.' --template '{node}'`
- cd /tmp/mercurial-ci/ - cd /tmp/mercurial-ci/
- make local PYTHON=$PYTHON - make local PYTHON=$PYTHON
- $PYTHON -m pip install --user -U pytype==2021.04.15 - $PYTHON -m pip install --user -U pytype==2021.04.15
variables: variables:
RUNTEST_ARGS: " --allow-slow-tests tests/test-check-pytype.t" RUNTEST_ARGS: " --allow-slow-tests tests/test-check-pytype.t --timeout 3600"
PYTHON: python3 PYTHON: python3
TEST_HGMODULEPOLICY: "c" TEST_HGMODULEPOLICY: "c"
# `sh.exe --login` sets a couple of extra environment variables that are defined # `sh.exe --login` sets a couple of extra environment variables that are defined
# in the MinGW shell, but switches CWD to /home/$username. The previous value # in the MinGW shell, but switches CWD to /home/$username. The previous value
# is stored in OLDPWD. Of the added variables, MSYSTEM is crucial to running # is stored in OLDPWD. Of the added variables, MSYSTEM is crucial to running
# run-tests.py- it is needed to make run-tests.py generate a `python3` script # run-tests.py- it is needed to make run-tests.py generate a `python3` script
# that satisfies the various shebang lines and delegates to `py -3`. # that satisfies the various shebang lines and delegates to `py -3`.