This is an archive of the discontinued Mercurial Phabricator instance.

test-dispatch: make the test compatible with chg
ClosedPublic

Authored by singhsrb on Oct 16 2017, 7:52 PM.

Download Raw Diff

Details

Reviewers

quark
durin42

Group Reviewers

hg-reviewers

Commits

rHG1ddc2547749f: test-dispatch: make the test compatible with chg
rHG65a2c4114158: test-dispatch: make the test compatible with chg

Summary

The test is broken when run with chg because it prints a different
error message when chg is running. This commit fixes the test by special casing
for chg.

Test Plan

Ran the test 'test-dispatch.t' with and without '--chg' option.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 16 2017, 7:52 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 16 2017, 7:52 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

Just a small nit.

tests/test-dispatch.t
72–73	Alternatively, you can use individual line matching without duplicating the `hg version` line: abort: error getting current working directory: * (glob) (no-chg !) chg: abort: failed to getcwd (errno = *) (glob) (chg !)
81	`errno` and error message could be platform dependent: chg: ... (errno = *) (glob)

This revision now requires changes to proceed.Oct 16 2017, 7:56 PM

singhsrb added inline comments.Oct 16 2017, 8:10 PM

tests/test-dispatch.t
72–73	That certainly seems like a better approach. Thanks!
81	Hmmm, didn't consider that. Thanks!

singhsrb updated this revision to Diff 2852.Oct 16 2017, 8:15 PM

quark accepted this revision.Oct 16 2017, 8:16 PM

durin42 accepted this revision.Oct 16 2017, 9:32 PM

This revision is now accepted and ready to land.Oct 16 2017, 9:32 PM

Closed by commit rHG65a2c4114158: test-dispatch: make the test compatible with chg (authored by singhsrb). · Explain WhyOct 16 2017, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-dispatch.t (3 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	2850		Oct 16 2017, 7:52 PM	★	★
Diff 2	2852		Oct 16 2017, 8:15 PM	★	★
Diff 3	2869	rHG65a2c4114158815740bfae98cb4d2ea751e0657a	Oct 16 2017, 8:14 PM	★	★

Diff 2869

tests/test-dispatch.t

	#if rmcwd			#if rmcwd

	Current directory removed:			Current directory removed:

	$ mkdir $TESTTMP/repo1			$ mkdir $TESTTMP/repo1
	$ cd $TESTTMP/repo1			$ cd $TESTTMP/repo1
	$ rm -rf $TESTTMP/repo1			$ rm -rf $TESTTMP/repo1
	$ HGDEMANDIMPORT=disable hg version -q			$ HGDEMANDIMPORT=disable hg version -q
	abort: error getting current working directory: * (glob)			abort: error getting current working directory: * (glob) (no-chg !)
				chg: abort: failed to getcwd (errno = *) (glob) (chg !)
				quarkUnsubmitted Not Done Alternatively, you can use individual line matching without duplicating the `hg version` line: abort: error getting current working directory: * (glob) (no-chg !) chg: abort: failed to getcwd (errno = ) (glob) (chg !) quark:* Alternatively, you can use individual line matching without duplicating the `hg version` line…
				singhsrbAuthorUnsubmitted Not Done That certainly seems like a better approach. Thanks! singhsrb: That certainly seems like a better approach. Thanks!
	[255]			[255]

	#endif			#endif
				quarkUnsubmitted Not Done `errno` and error message could be platform dependent: chg: ... (errno = ) (glob) quark:* `errno` and error message could be platform dependent: chg: ... (errno = *) (glob)
				singhsrbAuthorUnsubmitted Not Done Hmmm, didn't consider that. Thanks! singhsrb: Hmmm, didn't consider that. Thanks!