This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11309

check-code: drop the camelcase checks
ClosedPublic

Authored by marmoute on Aug 19 2021, 2:12 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG142a76127e3a: check-code: drop the camelcase checks
Summary

Fro about 2 years we have been using CamelCase is class names. That rules gets
in the way of assigning class or exception in compatibility layers.

I think it is safe to drop it now that we started using CamelCase for some case.

My motivation for this is the need to assign FileNotFoundError in pycompat.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 19 2021, 2:12 PM
marmoute added a commit: rHG142a76127e3a: check-code: drop the camelcase checks.Aug 22 2021, 4:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG142a76127e3a: check-code: drop the camelcase checks (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (5 lines)

Diff 29982

contrib/check-code.py

# a pass at the same indent level, which is bogus # a pass at the same indent level, which is bogus
r'(?P=indent)pass[ \t\n#]' r'(?P=indent)pass[ \t\n#]'
), ),
'omit superfluous pass', 'omit superfluous pass',
), ),
(r'[^\n]\Z', "no trailing newline"), (r'[^\n]\Z', "no trailing newline"),
(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"), (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
( (
r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',
"don't use camelcase in identifiers",
r'#.*camelcase-required',
),
(
r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+', r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
"linebreak after :", "linebreak after :",
), ),
( (
r'class\s[^( \n]+:', r'class\s[^( \n]+:',
"old-style class, use class foo(object)", "old-style class, use class foo(object)",
r'#.*old-style', r'#.*old-style',
), ),