This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11313

dirstate: directly call the dirstatemap in `set_untracked`
ClosedPublic

Authored by marmoute on Aug 21 2021, 5:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1c797757f5bb: dirstate: directly call the dirstatemap in `set_untracked`
Summary

This function is only called in two places: the deprecated "remove" method and
in the new set_untracked method.

So we simply inline the appropriate content in set_untraked, paving the way
to dropping the deprecated code and its associated function.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 21 2021, 5:55 AM
marmoute added a commit: rHG1c797757f5bb: dirstate: directly call the dirstatemap in `set_untracked`.Aug 22 2021, 5:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG1c797757f5bb: dirstate: directly call the dirstatemap in `set_untracked` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (4 lines)

Diff 29986

mercurial/dirstate.py

""" """
entry = self._map.get(filename) entry = self._map.get(filename)
if entry is None: if entry is None:
return False return False
elif entry.added: elif entry.added:
self._drop(filename) self._drop(filename)
return True return True
else: else:
self._remove(filename) self._dirty = True
self._updatedfiles.add(filename)
self._map.removefile(filename, in_merge=self.in_merge)
return True return True
@requires_no_parents_change @requires_no_parents_change
def set_clean(self, filename, parentfiledata=None): def set_clean(self, filename, parentfiledata=None):
"""record that the current state of the file on disk is known to be clean""" """record that the current state of the file on disk is known to be clean"""
self._dirty = True self._dirty = True
self._updatedfiles.add(filename) self._updatedfiles.add(filename)
self._normal(filename, parentfiledata=parentfiledata) self._normal(filename, parentfiledata=parentfiledata)