This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11450

check-code: make it possible to ignore the PWD check in some situation
ClosedPublic

Authored by marmoute on Sep 17 2021, 3:05 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHGb84fe613de33: check-code: make it possible to ignore the PWD check in some situation

Summary

The check-code script does not motivate the banning of $PWD so I am not sure
what it is about. And I will needs to use the env variable in the next tests. So
I am adding a way to make an exception.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 17 2021, 3:05 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptSep 17 2021, 3:05 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D11449: tests: make removeemptydirs more portable.Sep 17 2021, 3:05 PM

marmoute added a commit: rHGb84fe613de33: check-code: make it possible to ignore the PWD check in some situation.Sep 19 2021, 3:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHGb84fe613de33: check-code: make it possible to ignore the PWD check in some situation (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contrib/check-code.py (2 lines)

	Status	Author	Revision
	Closed	marmoute	D11449 tests: make removeemptydirs more portable
	Closed	marmoute	D11450 check-code: make it possible to ignore the PWD check in some situation

Diff 30301

contrib/check-code.py

	"don't use 'find -printf', it doesn't exist on BSD find(1)",			"don't use 'find -printf', it doesn't exist on BSD find(1)",
	),			),
	(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),			(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
	],			],
	# warnings			# warnings
	[			[
	(r'^function', "don't use 'function', use old style"),			(r'^function', "don't use 'function', use old style"),
	(r'^diff.-\wN', "don't use 'diff -N'"),			(r'^diff.-\wN', "don't use 'diff -N'"),
	(r'\$PWD\|\${PWD}', "don't use $PWD, use `pwd`"),			(r'\$PWD\|\${PWD}', "don't use $PWD, use `pwd`", "no-pwd-check"),
	(r'^([^"\'\n]\|("[^"\n]")\|(\'[^\'\n]\'))*\^', "^ must be quoted"),			(r'^([^"\'\n]\|("[^"\n]")\|(\'[^\'\n]\'))*\^', "^ must be quoted"),
	(r'kill (`\|\$\()', "don't use kill, use killdaemons.py"),			(r'kill (`\|\$\()', "don't use kill, use killdaemons.py"),
	],			],
	]			]

	testfilters = [			testfilters = [
	(r"( )(#([^!][^\n]\S)?)", repcomment),			(r"( )(#([^!][^\n]\S)?)", repcomment),
	(r"<<(\S+)((.\|\n)*?\n\1)", rephere),			(r"<<(\S+)((.\|\n)*?\n\1)", rephere),

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	30292		Sep 17 2021, 3:04 PM	★	★
Diff 2	30301	rHGb84fe613de3316f5806cf20b66f7e2c59690027a	Sep 17 2021, 3:04 PM	★	★