This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1161

hghave: disable demandimport when chg is running
ClosedPublic

Authored by singhsrb on Oct 17 2017, 2:20 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHG88624b40a9cb: hghave: disable demandimport when chg is running
Summary

Chg disables demandimport on purpose for performance wins and
therefore, it probably makes sense to indicate that demandimport is disabled
when chg is running.

Test Plan

Ran all the tests.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 17 2017, 2:20 PM
quark added a subscriber: quark.Oct 17 2017, 2:26 PM
quark added inline comments.
tests/hghave.py
604–605

It's more accurate saying:

# chg disables demandimport on purpose

chg could support demandimport but chooses to disable it for performance win.

singhsrb added inline comments.Oct 17 2017, 2:30 PM
tests/hghave.py
604–605

Yes, that does looks like a better way to put it. I will update the commit message as well to reflect the same.

singhsrb edited the summary of this revision. (Show Details)Oct 17 2017, 2:39 PM
singhsrb retitled this revision from hghave: make 'on demand import' unsupported when chg is running to hghave: disable demandimport when chg is running.
singhsrb updated this revision to Diff 2940.
quark accepted this revision.Oct 17 2017, 5:21 PM
Closed by commit rHG88624b40a9cb: hghave: disable demandimport when chg is running (authored by singhsrb). · Explain WhyOct 18 2017, 8:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (3 lines)

Diff 2969

tests/hghave.py

"debian build dependencies (run dpkg-checkbuilddeps in contrib/)") "debian build dependencies (run dpkg-checkbuilddeps in contrib/)")
def has_debdeps(): def has_debdeps():
# just check exit status (ignoring output) # just check exit status (ignoring output)
path = '%s/../contrib/debian/control' % os.environ['TESTDIR'] path = '%s/../contrib/debian/control' % os.environ['TESTDIR']
return matchoutput('dpkg-checkbuilddeps %s' % path, br'') return matchoutput('dpkg-checkbuilddeps %s' % path, br'')
@check("demandimport", "demandimport enabled") @check("demandimport", "demandimport enabled")
def has_demandimport(): def has_demandimport():
return os.environ.get('HGDEMANDIMPORT') != 'disable' # chg disables demandimport intentionally for performance wins.
return ((not has_chg()) and os.environ.get('HGDEMANDIMPORT') != 'disable')
quarkUnsubmitted
Not Done

It's more accurate saying:

# chg disables demandimport on purpose

chg could support demandimport but chooses to disable it for performance win.

quark: It's more accurate saying: ``` # chg disables demandimport on purpose ``` chg could support…
singhsrbAuthorUnsubmitted
Not Done

Yes, that does looks like a better way to put it. I will update the commit message as well to reflect the same.

singhsrb: Yes, that does looks like a better way to put it. I will update the commit message as well to…
@check("py3k", "running with Python 3.x") @check("py3k", "running with Python 3.x")
def has_py3k(): def has_py3k():
return 3 == sys.version_info[0] return 3 == sys.version_info[0]
@check("py3exe", "a Python 3.x interpreter is available") @check("py3exe", "a Python 3.x interpreter is available")
def has_python3exe(): def has_python3exe():
return 'PYTHON3' in os.environ return 'PYTHON3' in os.environ