( )⚙ D11617 rhg: in rhg cat cli, fix the long name of the --rev flag

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11617

rhg: in rhg cat cli, fix the long name of the --rev flag
ClosedPublic

Authored by aalekseyev on Oct 5 2021, 11:09 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG08c8cd2527bc: rhg: in rhg cat cli, fix the long name of the --rev flag
Summary

Also tweak the help for the anonymous argument.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

aalekseyev created this revision.Oct 5 2021, 11:09 AM
aalekseyev retitled this revision from rhg: in rhg cat cli, fix the long name of the --rev flag\n\nAlso tweak the help for the anonymous argument. to rhg: in rhg cat cli, fix the long name of the --rev flag.Oct 5 2021, 11:15 AM
aalekseyev edited the summary of this revision. (Show Details)
martinvonz accepted this revision.Oct 8 2021, 9:24 PM
This revision is now accepted and ready to land.Oct 8 2021, 9:24 PM

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/commands/cat.rs (4 lines)
Mtests/test-rhg.t (2 lines)

Diff 30680

rust/rhg/src/commands/cat.rs

"; ";
pub fn args() -> clap::App<'static, 'static> { pub fn args() -> clap::App<'static, 'static> {
clap::SubCommand::with_name("cat") clap::SubCommand::with_name("cat")
.arg( .arg(
Arg::with_name("rev") Arg::with_name("rev")
.help("search the repository as it is in REV") .help("search the repository as it is in REV")
.short("-r") .short("-r")
.long("--revision") .long("--rev")
.value_name("REV") .value_name("REV")
.takes_value(true), .takes_value(true),
) )
.arg( .arg(
clap::Arg::with_name("files") clap::Arg::with_name("files")
.required(true) .required(true)
.multiple(true) .multiple(true)
.empty_values(false) .empty_values(false)
.value_name("FILE") .value_name("FILE")
.help("Activity to start: activity@category"), .help("Files to output"),
) )
.about(HELP_TEXT) .about(HELP_TEXT)
} }
#[timed] #[timed]
pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> { pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> {
let rev = invocation.subcommand_args.value_of("rev"); let rev = invocation.subcommand_args.value_of("rev");
let file_args = match invocation.subcommand_args.values_of("files") { let file_args = match invocation.subcommand_args.values_of("files") {

tests/test-rhg.t

91c6f6e73e39318534dc415ea4e8a09c99cd74d6 91c6f6e73e39318534dc415ea4e8a09c99cd74d6
6ae9681c6d30389694d8701faf24b583cf3ccafe 6ae9681c6d30389694d8701faf24b583cf3ccafe
$ $NO_FALLBACK rhg files -r cf8b83 $ $NO_FALLBACK rhg files -r cf8b83
file-1 file-1
file-2 file-2
file-3 file-3
$ $NO_FALLBACK rhg cat -r cf8b83 file-2 $ $NO_FALLBACK rhg cat -r cf8b83 file-2
2 2
$ $NO_FALLBACK rhg cat --rev cf8b83 file-2
2
$ $NO_FALLBACK rhg cat -r c file-2 $ $NO_FALLBACK rhg cat -r c file-2
abort: ambiguous revision identifier: c abort: ambiguous revision identifier: c
[255] [255]
$ $NO_FALLBACK rhg cat -r d file-2 $ $NO_FALLBACK rhg cat -r d file-2
2 2
$ $NO_FALLBACK rhg cat -r 0000 file-2 $ $NO_FALLBACK rhg cat -r 0000 file-2
abort: invalid revision identifier: 0000 abort: invalid revision identifier: 0000
[255] [255]