This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11683

fix: appease pyflakes and make unused variables more obvious
ClosedPublic

Authored by Alphare on Oct 18 2021, 5:35 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG2f7caef017d9: fix: appease pyflakes and make unused variables more obvious
Summary

pyflakes is complaining that baserevs is redefined by the list comprehension,
and while this lint can be valuable, it's not actually a problem here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 18 2021, 5:35 AM
pulkit accepted this revision.Oct 18 2021, 10:41 AM
This revision is now accepted and ready to land.Oct 18 2021, 10:41 AM

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (2 lines)

Diff 30881

hgext/fix.py

% (util.bytecount(maxfilesize), path) % (util.bytecount(maxfilesize), path)
) )
continue continue
baserevs = tuple(ctx.rev() for ctx in basectxs[rev]) baserevs = tuple(ctx.rev() for ctx in basectxs[rev])
dstrevmap[(fctx.filerev(), baserevs, path)].append(rev) dstrevmap[(fctx.filerev(), baserevs, path)].append(rev)
numitems[rev] += 1 numitems[rev] += 1
workqueue = [ workqueue = [
(min(dstrevs), path, dstrevs) (min(dstrevs), path, dstrevs)
for (filerev, baserevs, path), dstrevs in dstrevmap.items() for (_filerev, _baserevs, path), dstrevs in dstrevmap.items()
] ]
# Move work items for earlier changesets to the front of the queue, so we # Move work items for earlier changesets to the front of the queue, so we
# might be able to replace those changesets (in topological order) while # might be able to replace those changesets (in topological order) while
# we're still processing later work items. Note the min() in the previous # we're still processing later work items. Note the min() in the previous
# expression, which means we don't need a custom comparator here. The path # expression, which means we don't need a custom comparator here. The path
# is also important in the sort order to make the output order stable. There # is also important in the sort order to make the output order stable. There
# are some situations where this doesn't help much, but some situations # are some situations where this doesn't help much, but some situations
# where it lets us buffer O(1) files instead of O(n) files. # where it lets us buffer O(1) files instead of O(n) files.