This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11690

python: compatibility for python 3.11 (issue6604)
ClosedPublic

Authored by Alphare on Oct 19 2021, 10:09 AM.

Details

Reviewers
spectral
Group Reviewers
hg-reviewers
Commits
rHG3a95a4e660b9: python: compatibility for python 3.11 (issue6604)
rHGcc9acd2c6fd0: python: compatibility for python 3.11 (issue6604)
Summary

The unittest._TextTestResult alias has been removed.
The "new" name has been available since 3.2, and we only support 3.5.3+.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 19 2021, 10:09 AM
spectral accepted this revision.Oct 19 2021, 5:01 PM
Alphare added a commit: rHGcc9acd2c6fd0: python: compatibility for python 3.11 (issue6604).Oct 20 2021, 11:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGcc9acd2c6fd0: python: compatibility for python 3.11 (issue6604) (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/basic_test_result.py (8 lines)
Mtests/run-tests.py (11 lines)

Diff 30955

tests/basic_test_result.py

from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import sys
import unittest import unittest
if sys.version_info[0] < 3:
base_class = unittest._TextTestResult
else:
base_class = unittest.TextTestResult
class TestResult(unittest._TextTestResult):
class TestResult(base_class):
def __init__(self, options, *args, **kwargs): def __init__(self, options, *args, **kwargs):
super(TestResult, self).__init__(*args, **kwargs) super(TestResult, self).__init__(*args, **kwargs)
self._options = options self._options = options
# unittest.TestResult didn't have skipped until 2.7. We need to # unittest.TestResult didn't have skipped until 2.7. We need to
# polyfill it. # polyfill it.
self.skipped = [] self.skipped = []

tests/run-tests.py

def _stringescape(s): def _stringescape(s):
return TTest.ESCAPESUB(TTest._escapef, s) return TTest.ESCAPESUB(TTest._escapef, s)
iolock = threading.RLock() iolock = threading.RLock()
firstlock = threading.RLock() firstlock = threading.RLock()
firsterror = False firsterror = False
if PYTHON3:
base_class = unittest.TextTestResult
else:
base_class = unittest._TextTestResult
class TestResult(unittest._TextTestResult): class TestResult(base_class):
"""Holds results when executing via unittest.""" """Holds results when executing via unittest."""
# Don't worry too much about accessing the non-public _TextTestResult.
# It is relatively common in Python testing tools.
def __init__(self, options, *args, **kwargs): def __init__(self, options, *args, **kwargs):
super(TestResult, self).__init__(*args, **kwargs) super(TestResult, self).__init__(*args, **kwargs)
self._options = options self._options = options
# unittest.TestResult didn't have skipped until 2.7. We need to # unittest.TestResult didn't have skipped until 2.7. We need to
# polyfill it. # polyfill it.
self.skipped = [] self.skipped = []