( )⚙ D11710 pyoxidizer: force pip to not use pep517 in order to still be able to install hg

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11710

pyoxidizer: force pip to not use pep517 in order to still be able to install hg
ClosedPublic

Authored by Alphare on Oct 20 2021, 11:04 AM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

None

Group Reviewers

Commits

rHGf6b045910d82: pyoxidizer: force pip to not use pep517 in order to be able to install hg
rHGe95fd116c968: pyoxidizer: force pip to not use pep517 in order to be able to install hg
rHGf2694f9d90dc: pyoxidizer: force pip to not use pep517 in order to still be able to install hg

Summary

Mercurial is not (yet) a pep517 package, but the presence of a pyproject.toml
file tells newer-ish versions of pip that it should be one.

This is related to 58fe6d127a01, and fixes pyoxidizer builds for the Heptapod
CI.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 20 2021, 11:04 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 20 2021, 11:04 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

Alphare added a commit: rHGf2694f9d90dc: pyoxidizer: force pip to not use pep517 in order to still be able to install hg.Oct 20 2021, 11:15 AM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHGf2694f9d90dc: pyoxidizer: force pip to not use pep517 in order to still be able to install hg (authored by Alphare). · Explain Why

This revision was automatically updated to reflect the committed changes.

Alphare added a commit: rHGe95fd116c968: pyoxidizer: force pip to not use pep517 in order to be able to install hg.Oct 20 2021, 11:51 AM

Alphare added a commit: rHGf6b045910d82: pyoxidizer: force pip to not use pep517 in order to be able to install hg.Oct 21 2021, 3:27 AM

Revision Contents
Changeset List

			Path	Packages
M			rust/hgcli/pyoxidizer.bzl (2 lines)

Diff 30953

rust/hgcli/pyoxidizer.bzl


	exe = dist.to_python_executable(			exe = dist.to_python_executable(
	name = "hg",			name = "hg",
	packaging_policy = packaging_policy,			packaging_policy = packaging_policy,
	config = config,			config = config,
	)			)

	# Add Mercurial to resources.			# Add Mercurial to resources.
	exe.add_python_resources(exe.pip_install(["--verbose", ROOT]))			exe.add_python_resources(exe.pip_install(["--verbose", "--no-use-pep517", ROOT]))

	# On Windows, we install extra packages for convenience.			# On Windows, we install extra packages for convenience.
	if IS_WINDOWS:			if IS_WINDOWS:
	exe.add_python_resources(			exe.add_python_resources(
	exe.pip_install(["-r", ROOT + "/contrib/packaging/requirements-windows-py3.txt"]),			exe.pip_install(["-r", ROOT + "/contrib/packaging/requirements-windows-py3.txt"]),
	)			)
	extra_packages = VARS.get("extra_py_packages", "")			extra_packages = VARS.get("extra_py_packages", "")
	if extra_packages:			if extra_packages: