This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11717

heptapod-ci: actually give pytest more time before timeout
ClosedPublic

Authored by Alphare on Oct 21 2021, 8:03 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHGf3e218ae3fd9: heptapod-ci: actually give pytest more time before timeout
Summary

HGTEST_TIMEOUT is overridden by HGTEST_SLOWTIMEOUT for tests marked as
slow, which test-check-pytype.t is. So this whole time the timeout was 1500s
(or 25 minutes), which is unfortunately not long enough for a *lot* of the
times it's run on the CI.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Oct 21 2021, 8:03 AM
marmoute added a subscriber: marmoute.Oct 21 2021, 8:43 AM

Looks good:

note: we should probably make the "slow timeout" the max of HGTEST_TIMEOUT and HGTEST_SLOWTIMEOUT

marmoute accepted this revision.Oct 21 2021, 8:43 AM
Alphare added a commit: rHGf3e218ae3fd9: heptapod-ci: actually give pytest more time before timeout.Oct 21 2021, 10:41 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGf3e218ae3fd9: heptapod-ci: actually give pytest more time before timeout (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 30972.Oct 21 2021, 11:11 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Revision Contents
Changeset List

PathPackages
Mcontrib/heptapod-ci.yml (2 lines)

Diff 30972

contrib/heptapod-ci.yml

before_script: before_script:
- hg clone . /tmp/mercurial-ci/ --noupdate --config phases.publish=no - hg clone . /tmp/mercurial-ci/ --noupdate --config phases.publish=no
- hg -R /tmp/mercurial-ci/ update `hg log --rev '.' --template '{node}'` - hg -R /tmp/mercurial-ci/ update `hg log --rev '.' --template '{node}'`
- cd /tmp/mercurial-ci/ - cd /tmp/mercurial-ci/
- make local PYTHON=$PYTHON - make local PYTHON=$PYTHON
- $PYTHON -m pip install --user -U pytype==2021.04.15 - $PYTHON -m pip install --user -U pytype==2021.04.15
variables: variables:
RUNTEST_ARGS: " --allow-slow-tests tests/test-check-pytype.t" RUNTEST_ARGS: " --allow-slow-tests tests/test-check-pytype.t"
HGTEST_TIMEOUT: "3600" HGTEST_SLOWTIMEOUT: "3600"
PYTHON: python3 PYTHON: python3
TEST_HGMODULEPOLICY: "c" TEST_HGMODULEPOLICY: "c"
# `sh.exe --login` sets a couple of extra environment variables that are defined # `sh.exe --login` sets a couple of extra environment variables that are defined
# in the MinGW shell, but switches CWD to /home/$username. The previous value # in the MinGW shell, but switches CWD to /home/$username. The previous value
# is stored in OLDPWD. Of the added variables, MSYSTEM is crucial to running # is stored in OLDPWD. Of the added variables, MSYSTEM is crucial to running
# run-tests.py- it is needed to make run-tests.py generate a `python3` script # run-tests.py- it is needed to make run-tests.py generate a `python3` script
# that satisfies the various shebang lines and delegates to `py -3`. # that satisfies the various shebang lines and delegates to `py -3`.