( )⚙ D11732 compat: don't rely on cpython-specific builtins manipulation

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11732

compat: don't rely on cpython-specific builtins manipulation
ClosedPublic

Authored by Alphare on Nov 3 2021, 7:37 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6ffcaba7d122: compat: don't rely on cpython-specific builtins manipulation
Summary

Pierre Augier signaled on the mailing list that this fails on Pypy and pointed
out the correct solution.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Nov 3 2021, 7:37 AM
Alphare added a commit: rHG6ffcaba7d122: compat: don't rely on cpython-specific builtins manipulation.Nov 3 2021, 12:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG6ffcaba7d122: compat: don't rely on cpython-specific builtins manipulation (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pycompat.py (3 lines)

Diff 31012

mercurial/pycompat.py

def future_set_exception_info(f, exc_info): def future_set_exception_info(f, exc_info):
f.set_exception_info(*exc_info) f.set_exception_info(*exc_info)
# this is close enough for our usage # this is close enough for our usage
FileNotFoundError = OSError FileNotFoundError = OSError
else: else:
import builtins
import concurrent.futures as futures import concurrent.futures as futures
import http.cookiejar as cookielib import http.cookiejar as cookielib
import http.client as httplib import http.client as httplib
import pickle import pickle
import queue as queue import queue as queue
import socketserver import socketserver
import xmlrpc.client as xmlrpclib import xmlrpc.client as xmlrpclib
def future_set_exception_info(f, exc_info): def future_set_exception_info(f, exc_info):
f.set_exception(exc_info[0]) f.set_exception(exc_info[0])
FileNotFoundError = __builtins__['FileNotFoundError'] FileNotFoundError = builtins.FileNotFoundError
def identity(a): def identity(a):
return a return a
def _rapply(f, xs): def _rapply(f, xs):
if xs is None: if xs is None: