Page MenuHomePhabricator

tests: dd status=noxfer is not portable (issue6523)
ClosedPublic

Authored by wiz on Nov 14 2021, 6:13 PM.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

wiz created this revision.Nov 14 2021, 6:13 PM
Alphare requested changes to this revision.Nov 15 2021, 5:48 AM
Alphare added a subscriber: Alphare.

It seems that this fix is not throwing a wide enough net: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/263833

I'm not exactly sure what the right matching would be.

This revision now requires changes to proceed.Nov 15 2021, 5:48 AM
wiz added a comment.Nov 15 2021, 5:54 AM

Should we go

* bytes *

or just ignore the line completely with

*

?

In D11754#180358, @wiz wrote:

Should we go

* bytes *

This is probably the best we can do, seems fine. Thanks for the patches!

wiz updated this revision to Diff 31064.Nov 15 2021, 6:04 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.