( )⚙ D11754 tests: dd status=noxfer is not portable (issue6523)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11754

tests: dd status=noxfer is not portable (issue6523)
ClosedPublic

Authored by wiz on Nov 14 2021, 6:13 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG141e38ef8d8f: tests: dd status=noxfer is not portable (issue6523)

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

wiz created this revision.Nov 14 2021, 6:13 PM
Alphare requested changes to this revision.Nov 15 2021, 5:48 AM
Alphare added a subscriber: Alphare.

It seems that this fix is not throwing a wide enough net: https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/263833

I'm not exactly sure what the right matching would be.

This revision now requires changes to proceed.Nov 15 2021, 5:48 AM
wiz added a comment.Nov 15 2021, 5:54 AM

Should we go

* bytes *

or just ignore the line completely with

*

?

Alphare added a comment.Nov 15 2021, 6:00 AM
In D11754#180358, @wiz wrote:

Should we go

* bytes *

This is probably the best we can do, seems fine. Thanks for the patches!

wiz updated this revision to Diff 31064.Nov 15 2021, 6:04 AM
wiz added a commit: rHG141e38ef8d8f: tests: dd status=noxfer is not portable (issue6523).Nov 15 2021, 11:45 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG141e38ef8d8f: tests: dd status=noxfer is not portable (issue6523) (authored by wiz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-persistent-nodemap.t (3 lines)

Diff 31064

tests/test-persistent-nodemap.t

corruption-test-repo/.hg/store/00changelog.i corruption-test-repo/.hg/store/00changelog.i
corruption-test-repo/.hg/store/00changelog.n corruption-test-repo/.hg/store/00changelog.n
truncate the file truncate the file
$ datafilepath=`ls corruption-test-repo/.hg/store/00changelog*.nd` $ datafilepath=`ls corruption-test-repo/.hg/store/00changelog*.nd`
$ f -s $datafilepath $ f -s $datafilepath
corruption-test-repo/.hg/store/00changelog-*.nd: size=121088 (glob) corruption-test-repo/.hg/store/00changelog-*.nd: size=121088 (glob)
$ dd if=$datafilepath bs=1000 count=10 of=$datafilepath-tmp status=noxfer $ dd if=$datafilepath bs=1000 count=10 of=$datafilepath-tmp
10+0 records in 10+0 records in
10+0 records out 10+0 records out
* bytes * (glob)
$ mv $datafilepath-tmp $datafilepath $ mv $datafilepath-tmp $datafilepath
$ f -s $datafilepath $ f -s $datafilepath
corruption-test-repo/.hg/store/00changelog-*.nd: size=10000 (glob) corruption-test-repo/.hg/store/00changelog-*.nd: size=10000 (glob)
Check that Mercurial reaction to this event Check that Mercurial reaction to this event
$ hg -R corruption-test-repo log -r . --traceback $ hg -R corruption-test-repo log -r . --traceback
changeset: 5005:90d5d3ba2fc4 changeset: 5005:90d5d3ba2fc4