This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11841

dirstate: drop comparison primitive on the timestamp class
ClosedPublic

Authored by marmoute on Dec 2 2021, 2:03 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG8d585aa9becf: dirstate: drop comparison primitive on the timestamp class
Summary

All comparison are now managed without using operator :

  • the status mtime comparisons is handled by the DirstateItem,
  • the fixup reliability check,
  • the update "hack".

So we no longer needs the operator and should discourage its usage.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstateutils/timestamp.py (23 lines)

Diff 31286

mercurial/dirstateutils/timestamp.py

# Copyright Mercurial Contributors # Copyright Mercurial Contributors
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
import functools import functools
import os import os
import stat import stat
from .. import error
rangemask = 0x7FFFFFFF rangemask = 0x7FFFFFFF
@functools.total_ordering @functools.total_ordering
class timestamp(tuple): class timestamp(tuple):
""" """
A Unix timestamp with optional nanoseconds precision, A Unix timestamp with optional nanoseconds precision,
""" """
def __new__(cls, value): def __new__(cls, value):
truncated_seconds, subsec_nanos = value truncated_seconds, subsec_nanos = value
value = (truncated_seconds & rangemask, subsec_nanos) value = (truncated_seconds & rangemask, subsec_nanos)
return super(timestamp, cls).__new__(cls, value) return super(timestamp, cls).__new__(cls, value)
def __eq__(self, other): def __eq__(self, other):
self_secs, self_subsec_nanos = self raise error.ProgrammingError(
other_secs, other_subsec_nanos = other 'timestamp should never be compared directly'
return self_secs == other_secs and (
self_subsec_nanos == other_subsec_nanos
or self_subsec_nanos == 0
or other_subsec_nanos == 0
) )
def __gt__(self, other): def __gt__(self, other):
self_secs, self_subsec_nanos = self raise error.ProgrammingError(
other_secs, other_subsec_nanos = other 'timestamp should never be compared directly'
if self_secs > other_secs: )
return True
if self_secs < other_secs:
return False
if self_subsec_nanos == 0 or other_subsec_nanos == 0:
# they are considered equal, so not "greater than"
return False
return self_subsec_nanos > other_subsec_nanos
def get_fs_now(vfs): def get_fs_now(vfs):
"""return a timestamp for "now" in the current vfs """return a timestamp for "now" in the current vfs
This will raise an exception if no temporary files could be created. This will raise an exception if no temporary files could be created.
""" """
tmpfd, tmpname = vfs.mkstemp() tmpfd, tmpname = vfs.mkstemp()